Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200422141836.1964676-1-yamada.masahiro@socionext.com> <20200511191400.GA27107@bogus>
In-Reply-To: <20200511191400.GA27107@bogus>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 14 May 2020 03:33:39 +0900
Message-ID: <CAK7LNAQjnvh=8A6nz3Kb3xLQ=6Gz6=oVGNfPbCmCazAwt5wTwQ@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: at24: add microchip,24lc[0-9]+ to the
 compatible pattern
To:     Rob Herring <robh@kernel.org>
Cc:     DTML <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-i2c@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,


On Tue, May 12, 2020 at 4:14 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, 22 Apr 2020 23:18:36 +0900, Masahiro Yamada wrote:
> > arch/arm/boot/dts/uniphier-ref-daughter.dtsi has
> >
> >   compatible = "microchip,24lc128", "atmel,24c128";
> >
> > and 'make ARCH=arm dtbs_check' warns this:
> >
> >   eeprom@50: compatible: ['microchip,24lc128', 'atmel,24c128'] is not valid under any of the given schemas (Possible causes of the failure)
> >
> > Microchip 24LC128 is the device used on this board, and I see it in
> > https://www.microchip.com/wwwproducts/en/24LC128
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> >  Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Applied, thanks!


If it is not too late, can you correct the patch subject?


See the applied commit in linux-next.


Author: Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Wed Apr 22 23:18:36 2020 +0900

    dt-bindings: at24: add microchip, 24lc[0-9]+ to the compatible pattern


Please notice a space after 'microchip,'


And this is the patch I submitted:

https://lore.kernel.org/patchwork/patch/1229480/


No space after 'microchip,'


This is a patchwork bug.
It automatically inserts a space after a comma.
Patchwork adds various unpleasant modification,
and breaks the commit subject and log.

I reported this bug to patchwork ML, but
still not fixed...


-- 
Best Regards
Masahiro Yamada