Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp801432ybk; Wed, 13 May 2020 13:31:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUy0obmjFNjqMiMhpHOnlNGZQbnS9UmsV+NLq7YBHRtV+F5Z7LHH7XLFqsebMQyboEp9fK X-Received: by 2002:a17:907:20e5:: with SMTP id rh5mr830632ejb.72.1589401878711; Wed, 13 May 2020 13:31:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589401878; cv=none; d=google.com; s=arc-20160816; b=gZ5u2pe4VLtKkLZL9uvimN7NXdc1G6kcS8Oy2gNpsh8gcePr0N/h5MHIt+G3ORiDL4 xLYehL+g5PDaf9I9obBIZTC2eWRnuWNsU+LKp4VX53jlMVKbtNmqBchy6Dw7b3GSibTl fTD/nn3o+dl375BnQbwyncQqSgsebTaLPp+J4ikCan3sDIfz05QEFZhLVdHPDDguFB+o kLwKBJV13924MUt1DL6oxw2SrFn4QGBnR22ERueZkLOArCiqesoyX6mFusy5PlYFa+xo pfhBzd+iKQXAnz+Oq1yKCjGAz4earhzDfIxSW48/V6XjPvmxazFzMdCbGkVYU2IJsuuv sR3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TWbyyoXjQ8xychCEE8IyM4rAjqH4M8UGx9hGGOtx4A4=; b=VoYWK3ifnSUabxDoWGYRvco3u2+s73pK8jDFlzzEFfc7LxrZRWUGdr8x72vMCRzmJ1 wF/ZUaBpuTFVP/QU0eEVqMv4tJn4QhdFF6qZ5BK3RqBZIUdK6sQ8Gqhf+8g4V3n0v0p3 t6wSvFZ3i/1dHhOp1T64UGaGdLC9sSM5qp/znEMpgNoQI3O3wJlF8juZ/XLlZ6iY6yNL YC7Cf9Ft4ADKHYcRUgrrpy7QEpDzqBr3Rkgy/b/+s76AivtrI67ALl0vjpKLu5gLN/e5 DULl4mf5BSgtnPiZLD9r9hiqjLDSDpgRF7j5q1W0KBHyUF2/YZM2vWVAZMxdgsUSukeV kJUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QzLpNXU+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z37si382934ede.339.2020.05.13.13.30.56; Wed, 13 May 2020 13:31:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QzLpNXU+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733273AbgEMJti (ORCPT + 99 others); Wed, 13 May 2020 05:49:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:48666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733257AbgEMJtd (ORCPT ); Wed, 13 May 2020 05:49:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E99D2493D; Wed, 13 May 2020 09:49:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363373; bh=FhvBPJNLASY6lwiZHMtDLrA+Rzd1BcGIVp+X4GlC4p0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QzLpNXU++sYv/c6nMThx5zsFZVGns2UId/JfwbJTINgJAQEVWqLykAwQHNNNg6FPt 78rri4ATXW92XpQLNqaQWCNNurBMdL1NF5q+0wgosM5YFJ4oc68yXVWPir3rX5xDwP 5g94uZt1KH+g53o0m3OzdBZqGKsUqRwITXmQLE8I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oliver Neukum , Johan Hovold , syzbot+d29e9263e13ce0b9f4fd@syzkaller.appspotmail.com Subject: [PATCH 5.4 48/90] USB: serial: garmin_gps: add sanity checking for data length Date: Wed, 13 May 2020 11:44:44 +0200 Message-Id: <20200513094413.913962011@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200513094408.810028856@linuxfoundation.org> References: <20200513094408.810028856@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Neukum commit e9b3c610a05c1cdf8e959a6d89c38807ff758ee6 upstream. We must not process packets shorter than a packet ID Signed-off-by: Oliver Neukum Reported-and-tested-by: syzbot+d29e9263e13ce0b9f4fd@syzkaller.appspotmail.com Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/garmin_gps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c @@ -1138,8 +1138,8 @@ static void garmin_read_process(struct g send it directly to the tty port */ if (garmin_data_p->flags & FLAGS_QUEUING) { pkt_add(garmin_data_p, data, data_length); - } else if (bulk_data || - getLayerId(data) == GARMIN_LAYERID_APPL) { + } else if (bulk_data || (data_length >= sizeof(u32) && + getLayerId(data) == GARMIN_LAYERID_APPL)) { spin_lock_irqsave(&garmin_data_p->lock, flags); garmin_data_p->flags |= APP_RESP_SEEN;