Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 May 2020 06:18:25 -0500
From:   Corey Minyard <cminyard@mvista.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     minyard@acm.org, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: ipmi: convert to use i2c_new_client_device()
Message-ID: <20200513111825.GB9928@minyard.net>
Reply-To: cminyard@mvista.com
References: <20200326210958.13051-2-wsa+renesas@sang-engineering.com>
 <20200512214532.14117-1-minyard@acm.org>
 <20200513083745.GC1043@ninjato>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200513083745.GC1043@ninjato>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 13, 2020 at 10:37:46AM +0200, Wolfram Sang wrote:
> On Tue, May 12, 2020 at 04:45:32PM -0500, minyard@acm.org wrote:
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > Move away from the deprecated API.
> > 
> > Based on a patch by Wolfram Sang <wsa+renesas@sang-engineering.com>.
> > 
> > Signed-off-by: Corey Minyard <cminyard@mvista.com>
> > ---
> > I think this works.
> 
> Yes, we can do it like this (despite the question from earlier if it is
> really needed). I fixed other drivers using this pattern, too.

I was wondering whether this is really needed, too, but I'm not 100%
sure it can be removed in all cases.  This is the safer route.

> 
> As Stephen Rothwell pointed out, you either need to remove my "From:" or
> add my SoB. I am fine with both.

It was enough of a rewrite that you as the author didn't seem right.
I've fixed the From line, sorry about that.

-corey

> 
> Thanks,
> 
>    Wolfram
>