Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp807672ybk; Wed, 13 May 2020 13:42:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvSLMhBCo7zupNDhu1qcujhFN/vuJw4eqRbwm4SLYHVm00rrMOcRjxbMy99lOC8aKdYZOL X-Received: by 2002:a50:9e2c:: with SMTP id z41mr1268213ede.193.1589402574587; Wed, 13 May 2020 13:42:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589402574; cv=none; d=google.com; s=arc-20160816; b=CQjcrxsaiv3Gj+rTIiGvb9K3BWtRY4/Fq490PzcDpfiR56Xg2XBo0dUdBLVxqYKcn6 maDMYUHaQBUavHrRDAJEIbONCtWlS/tj9bys85CN5n1IUz9DKST3AkxNK8/HzhlQcl0v OBKfW5bxF7kRKqWEdmjTeHGrwTyLZGXHiJrOQhWmNC1xHYBojAJBcOUkZsgfsdVSb3Oj PLgD/rLXrbi/9IAmmhTOUnVVlx0HZf0AdUX5hmX3xYzaQs7UfX1EhcR6+SSU8ANJJGLO OGwwynv+W6upjTBr1RrfM37sua1hvGSg8e4zdw2+y0854EpqG0ccmKl6fvNQAHNFMCEg MxwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=P4qgM1VsYJtv6avAn3oq9wFXCxAsUok2muLdgrtTjR0=; b=tot+yio54HDfIrIZGs5OrzpyRZWye/NYz5ciZf27QTep2G/1M3ehv85UcRpPQd70u0 sEivpuivajFTfxXvvhw6OkVHKuHu5hC3I2wtx/QF8pl/CSlzP0W+OCy27tkhpcan6pz/ UfeH1PX8kTSp5MJm7w4VLkM7x1McR0pNaDBuzSjl7Ev/rR8EkSL/hCfOVLen/+Vo5gLG vZyvJ6gno9vqW7C5DJ2EKZ2RN35Phf2Fsas+K+fYrENKDz+TnzWI0UGCgDySZtXzDGGx sUYcwt2byLKkXQqBNg8JmM2KIgBJeOKUK0siO/CB/xv72+51ueJyPpoS1zCf5dZdaj9F WjdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cnc+GvTz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si383436edr.583.2020.05.13.13.42.32; Wed, 13 May 2020 13:42:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cnc+GvTz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732973AbgEMNBU (ORCPT + 99 others); Wed, 13 May 2020 09:01:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:56878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731915AbgEMNBU (ORCPT ); Wed, 13 May 2020 09:01:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0B34205ED; Wed, 13 May 2020 13:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589374880; bh=m8GZsqelm6lKhj1/vT9jlMCK7f8Uw381Kw8/Ni5D3SA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cnc+GvTzNPW18mO7QUiUOBrXXrokRnBxI2VA+MOZYmC6mgLH/Jk9FbFAyvfu2czrq S+IFMqHEoqDbxs+ZPhruWFvRRHKfO7JTQkG/5IPjDEgmSMu2R7OxFxbzgx3+Kr5pRG PoIAZJj1qKtp2lnGhDiqltUfAv6G6rNokODR8ePo= Date: Wed, 13 May 2020 15:01:17 +0200 From: Greg KH To: Tang Bin Cc: Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Shengju Subject: Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Message-ID: <20200513130117.GA1085323@kroah.com> References: <9f88b0fd-28e9-2fa8-2deb-73652eb53fd4@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f88b0fd-28e9-2fa8-2deb-73652eb53fd4@cmss.chinamobile.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 08:55:59PM +0800, Tang Bin wrote: > Hi gregkh: > > On 2020/5/8 21:51, Alan Stern wrote: > > On Fri, 8 May 2020, Tang Bin wrote: > > > > > The function ehci_mxc_drv_probe() does not perform sufficient error > > > checking after executing platform_get_irq(), thus fix it. > > Aside from the "irq <= 0" issue, the Subject: line should say > > "ehci-mxc", not "ehci". > > > I know this patch need v2, whether just fix the subject? 0 is an invalid irq.