Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 13 May 2020 19:46:06 +0530
From:   "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Subject: Re: [PATCH] perf powerpc: Don't ignore sym-handling.c file
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Sandipan Das <sandipan@linux.ibm.com>
Cc:     jolsa@kernel.org, leo.yan@linaro.org, linux-kernel@vger.kernel.org,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>
References: <20200509112113.174745-1-ravi.bangoria@linux.ibm.com>
        <88066ce0-f586-b88d-75b5-2706684818d7@linux.ibm.com>
        <20200512132737.GH28888@kernel.org>
In-Reply-To: <20200512132737.GH28888@kernel.org>
MIME-Version: 1.0
User-Agent: astroid/v0.15-13-gb675b421
 (https://github.com/astroidmail/astroid)
Message-Id: <1589379305.x6l3ijih7z.naveen@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Arnaldo Carvalho de Melo wrote:
> Em Mon, May 11, 2020 at 11:45:09PM +0530, Sandipan Das escreveu:
>> 
>> On 09/05/20 4:51 pm, Ravi Bangoria wrote:
>> > Commit 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
>> > removed powerpc specific sym-handling.c file from Build. This wasn't
>> > caught by build CI because all functions in this file are declared
>> > as __weak in common code. Fix it.
>> > 
>> > Fixes: 7eec00a74720 ("perf symbols: Consolidate symbol fixup issue")
>> > Reported-by: Sandipan Das <sandipan@linux.ibm.com>
>> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
>> > ---
>> >  tools/perf/arch/powerpc/util/Build | 1 +
>> >  1 file changed, 1 insertion(+)
>> > 
>> > diff --git a/tools/perf/arch/powerpc/util/Build b/tools/perf/arch/powerpc/util/Build
>> > index e5c9504f8586..e86e210bf514 100644
>> > --- a/tools/perf/arch/powerpc/util/Build
>> > +++ b/tools/perf/arch/powerpc/util/Build
>> > @@ -2,6 +2,7 @@ perf-y += header.o
>> >  perf-y += kvm-stat.o
>> >  perf-y += perf_regs.o
>> >  perf-y += mem-events.o
>> > +perf-y += sym-handling.o
>> >  
>> >  perf-$(CONFIG_DWARF) += dwarf-regs.o
>> >  perf-$(CONFIG_DWARF) += skip-callchain-idx.o
>> > 
>> 
>> Thanks for fixing this!
>> 
>> Acked-by: Sandipan Das <sandipan@linux.ibm.com>
> 
> Leo, Naveen, can you comment on this?

Shoot -- this is a bad miss, I should have caught it. FWIW:
Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>

Thanks,
Naveen