Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp814622ybk; Wed, 13 May 2020 13:56:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPbFr1HHCOKLIeVjSK5XG4gVZr/Y7piMhM+bGix6RgBJwVKfg2SoQ3bEtjp0x+iQ79/5MO X-Received: by 2002:a17:906:944e:: with SMTP id z14mr931426ejx.86.1589403362260; Wed, 13 May 2020 13:56:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589403362; cv=none; d=google.com; s=arc-20160816; b=a6BmIfjydEa1m3h9evmqFTdervtUmnR9fz+2VQ/N8/8e0FIHBLOflSMTdOT2IuzxQl O2bbT8yNkrJ1Tc2lYooIXqQi702vJk4/+se35sCq+S5ik+3hr9zxaWTlZL5t06FG7owL Ee7bVRIRk/VsatGsKC0AdS3I1ujs0FhxBSJXhamMBnWW0nSsE4snoSDO+TwKL4sp9M+/ K/1JRxldLCDaph2etFTp/fZllszYa18aVm6Kl7/Tgk1exRqztiZEaUc6/x6PGKaQJXGt hIYScXPn/yXUdiFWkofHA+vGgX7U0SKyPpJQ4L40O9mMh/Im6sXIURYp5EDqBDtcHHb+ 4gfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=5FRYECFHiQr3Nfb1uzqLNFih4Bcng0OOjZJ5V5m4DAs=; b=xFPfud/ePwrGCNXtKRNlBjMfnpl6QGwPoUdiVj4rcO7CzIGEHXh6ZF5E1A0MXBcptT TwTTvAFPQArKZH0Oos/Dic8ItdXIEUpL5+XZ1BLM2RRo31LiAU1+szWYh5JF6s+n9NvQ W5hXzV9eoI9pwbjtWu33xLlbggVLNANRE9520b5dx0ByLwFFqbuu5Kq3Dq+GWaJ50UXk izi7qsXZ6JfC2tZrH5ln+YhfNE1XKH46BAX4Wymfq92kI0aDBoWMqEY80ob2FV8cjpZ2 H11LsBnkzE1eRs21TI3YBY/B5GfrjUDspmEoT2TpxXlrPnpMPbxHuRPtly+wD7vB0h3L RIiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ZjLEDdjh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si399844edm.596.2020.05.13.13.55.39; Wed, 13 May 2020 13:56:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ZjLEDdjh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390677AbgEMThf (ORCPT + 99 others); Wed, 13 May 2020 15:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2390708AbgEMThe (ORCPT ); Wed, 13 May 2020 15:37:34 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2514CC061A0F for ; Wed, 13 May 2020 12:37:33 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id a4so495411lfh.12 for ; Wed, 13 May 2020 12:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5FRYECFHiQr3Nfb1uzqLNFih4Bcng0OOjZJ5V5m4DAs=; b=ZjLEDdjhfQ+ZsfStprzo3boptGtjEB8xMJMPV9hfgVHHrrYSleH8mLbHC8Rk2rWQqc NnCj3BIzoVOHPTIgSoBKM0vWlfW3SuT0UoYyIfcumKGQE/4wsqoLb39sPYuJ5/AuOelG tGQKJ8l9ywdlX+FMm4CTzGEq2pztEwBhTbMlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5FRYECFHiQr3Nfb1uzqLNFih4Bcng0OOjZJ5V5m4DAs=; b=pLQaigKa9QPMADdkPBDYbMu2xdaTmcwxYO3mZtRhGdb/Mf5cJtL+8V2bfIfrzlqBWO sxMiuHnIB8u93CZUlhLpOqXqAnq7zg3GD2Eyrt0Qx6sl++QEiQZBXPrvuQT4buTGnhkp qb4F/679i1tPpyMRF3uPMkgNyKxkytJqhJA6EvgZ1e9HUFNE7yfwmQ/E+OUmf9xAwObB cVpwY4wsJhQgo5BQ7Y5rZVM/VbaTjRQkC8EvIbla28vM+UMyBhaKhhs9f48VLR6Yt0an QyMZ4J/xlvDKIgmr48VgnoyXRKc841ldJpnW7h/KCQoFD9bZWUdHihgPYfkaQeeTWkaz 1Tsw== X-Gm-Message-State: AOAM530r3+q+Tf2BTI4JUaHRhrf9sdM7bT4BHYeOt/9hXFwvr5MtZpRl z99mk4os5te62Ri7JDQn3VL9WG1oA4k= X-Received: by 2002:a19:d:: with SMTP id 13mr681662lfa.167.1589398650335; Wed, 13 May 2020 12:37:30 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id q7sm231433ljp.20.2020.05.13.12.37.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2020 12:37:29 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id s9so560913lfp.1 for ; Wed, 13 May 2020 12:37:28 -0700 (PDT) X-Received: by 2002:ac2:4da1:: with SMTP id h1mr686949lfe.152.1589398648496; Wed, 13 May 2020 12:37:28 -0700 (PDT) MIME-Version: 1.0 References: <20200513160038.2482415-1-hch@lst.de> In-Reply-To: <20200513160038.2482415-1-hch@lst.de> From: Linus Torvalds Date: Wed, 13 May 2020 12:37:12 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: clean up and streamline probe_kernel_* and friends v2 To: Christoph Hellwig Cc: "the arch/x86 maintainers" , Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Andrew Morton , linux-parisc@vger.kernel.org, linux-um , Netdev , bpf@vger.kernel.org, Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 9:00 AM Christoph Hellwig wrote: > > this series start cleaning up the safe kernel and user memory probing > helpers in mm/maccess.c, and then allows architectures to implement > the kernel probing without overriding the address space limit and > temporarily allowing access to user memory. It then switches x86 > over to this new mechanism by reusing the unsafe_* uaccess logic. Ok, I think I found a bug, and I had one more suggestion, but other than the two emails I sent this all looks like an improvement to me. Linus