Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp873748ybk; Wed, 13 May 2020 15:43:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyGFsDNxiwnC9zLOHj50Ful0DitUiJ52oYI8Ewe69Svv0MgP9Pf2jZXmL2jn3A3YyXikDQ X-Received: by 2002:a05:6402:1777:: with SMTP id da23mr1439526edb.92.1589409837052; Wed, 13 May 2020 15:43:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589409837; cv=none; d=google.com; s=arc-20160816; b=tdkbeGIvUvcz0o8uH/HNfxBkpcpDrdePnJEvRX7R6xyilzjkRebT658OWJtC+c65nG kYI67gdK42dsgtJ+Ut/6YB1b3XqwyGH5fN2MoKqGi5XAjwXy+ZAk+O7ot/xMLhlPUTGb loXCYJRFYdyEbRHgoAWj1iYez/0kxv2PYAl0iH8OvAVumpwBNSz3nQcbhHdtehcAfllF v2nDk9Uj0w80c7fm9ZMLmGIocO5kGrU75hoGyFMovC3cuaB+qpfBJgwe76PsDmAMt+Ho XFkPua1wcm2AeHIfCGi/xsDA+el9P5HPXAZbYoqaBJpU4pCGtSU/rsp83J0jK0Od9epV hhVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=PHPvS9R+1pv2uwONRJb9uT/s59iArV0AkhPsjVLJPMo=; b=KGObl6MwlJmXHhOPo70vrjVYVHy69yuzPygaLYBwhnwr5Oav/YdleFOSDUJYYkyFa0 tT1yuS0XCy0R6MIj5fmk/dm7LTCqeq/bLUbNIgrMuiQi5KjEE0lvu5EdgAz5UbjO5C71 w9Nt4+GM3oJIi1l5wPu+0rZI8PTgo4dBo9a/lqLzFBh3YYz6d8hJRTcOwbrR7MApsftl /m8E3irdfC6u6HfiLlcIJvRzi3sZ0LO9vNpmanAI1TrbO/HsuS1B+t2lajA/U5IhWIia lfcWJofFr17VUxlgGdvpd1iKvtbJsows36UwNYhTMsrnrhLq7cNWKsm70KeLJnk+xCx8 PsjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fl9UdENu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si717278eju.120.2020.05.13.15.43.34; Wed, 13 May 2020 15:43:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fl9UdENu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731043AbgEMWly (ORCPT + 99 others); Wed, 13 May 2020 18:41:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:57256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbgEMWly (ORCPT ); Wed, 13 May 2020 18:41:54 -0400 Received: from paulmck-ThinkPad-P72.home (unknown [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC876204EF; Wed, 13 May 2020 22:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589409713; bh=TctJClh3bXeDVJJ2/6XxJRe2TCYoY13ybyBMQN9qnE0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=fl9UdENus+D7MZ+ZWOYQt3WzKVKDuSrjbfB4Tqf+0cOEyHqJ7neqle4od9Iph3oJL r0YVIBMrHAqBdl6hwWutkFUnF7ZMLBFD9T8mgmyIWkx2RW3Qx4ANbcK0ATB52j3Onw Ngo8UF84Ui+ooaMVUQQI6qpp3dpBS9PKD/3SQyvQ= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 26799352352C; Wed, 13 May 2020 15:41:53 -0700 (PDT) Date: Wed, 13 May 2020 15:41:53 -0700 From: "Paul E. McKenney" To: Emil Velikov Cc: dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, Josh Triplett , rcu@vger.kernel.org Subject: Re: [PATCH 11/11] rcu: constify sysrq_key_op Message-ID: <20200513224153.GB2869@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200513214351.2138580-1-emil.l.velikov@gmail.com> <20200513214351.2138580-11-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513214351.2138580-11-emil.l.velikov@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 10:43:51PM +0100, Emil Velikov wrote: > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-kernel@vger.kernel.org > Cc: "Paul E. McKenney" > Cc: Josh Triplett > Cc: rcu@vger.kernel.org > Signed-off-by: Emil Velikov > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. Works for me: Reviewed-by: Paul E. McKenney > --- > kernel/rcu/tree_stall.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/rcu/tree_stall.h b/kernel/rcu/tree_stall.h > index 119ed6afd20f..4e6ed7b91f59 100644 > --- a/kernel/rcu/tree_stall.h > +++ b/kernel/rcu/tree_stall.h > @@ -729,7 +729,7 @@ static void sysrq_show_rcu(int key) > show_rcu_gp_kthreads(); > } > > -static struct sysrq_key_op sysrq_rcudump_op = { > +static const struct sysrq_key_op sysrq_rcudump_op = { > .handler = sysrq_show_rcu, > .help_msg = "show-rcu(y)", > .action_msg = "Show RCU tree", > -- > 2.25.1 >