Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp950133ybk; Wed, 13 May 2020 18:10:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsZPQcibXxSZCHfPnHoE8NBVEX6UVHTsOjfjPF1tqtxhYSK6sNv3F9aznCl5kauLikzcc5 X-Received: by 2002:a50:cdc3:: with SMTP id h3mr2025840edj.274.1589418620976; Wed, 13 May 2020 18:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589418620; cv=none; d=google.com; s=arc-20160816; b=yPc9BT0DP2aumBM4Qbenwu9aTKZRYK3SCQcyAMY4ELqdvHX4hwXmp8eTd12jaucExJ iigiY/OZ5dXBE+aTKVt1A0WEcDfqLZoaR10FbEuMAeqBMy1EkmehRR/IwcqN3BGN2Y/r KGfyWT1kx1mtfBYFVmT75bIcwDxG7mcYqi6HSfiBews1c5lWwyHSIcuTHby+Smi+xXS4 FbLfiidD6Pk+3zajJ5nsEeVKdzNAZHecivq+XPoV1X9L0eISJfhdhjMubOuoy2L+lZe8 u854BP5RcGSlT6T9KNa/99LozVyKl7OJ3mkgeXHGHEif3c8/TZGgWugWsVjusF3g5ceJ Djhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:dkim-signature:dkim-filter; bh=FhTyE8LWuX6WlUGlMBeaYWjm/Q1NP7kLXF6iw65/YUE=; b=DEUcLX5Lf8bVeN9AlUzX3AEuqpbvwelRMvfKpwwaSAB2nwx6QZ9B1RgrZdhAlfvC8z DQ69kk7kgnGS2sB0D4yaYLELGvLecQv0CO+8Ohf6f9vZ7FW3qTnhEw9Q3L95O4jjCQ3O f2eTSnE6ALWs+YSZoqcmGkVx0NfR+IU5XIPqANqnIEciMJcSBaUnAxHTHWPyBckrpzXq RfHsXE4Fo0eIub4ATQESLhcebZGPbjTsrPzVDq9W3beeCdti+OEJppfC4THExd+RXFg7 OTX1X2wH4nyB9EQ8AoWMyJeeWZnuBfrs5hU6giilOO2XZEh2fl7mnvQQpGVZ7q3T3/os mOBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@efficios.com header.s=default header.b=Q5YZfBJ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i15si859135ejy.126.2020.05.13.18.09.57; Wed, 13 May 2020 18:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@efficios.com header.s=default header.b=Q5YZfBJ+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726015AbgENBIc (ORCPT + 99 others); Wed, 13 May 2020 21:08:32 -0400 Received: from mail.efficios.com ([167.114.26.124]:57702 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbgENBIc (ORCPT ); Wed, 13 May 2020 21:08:32 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 45DB92A0C6E; Wed, 13 May 2020 21:08:31 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mEMohs7_FPtL; Wed, 13 May 2020 21:08:31 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 070712A0AFD; Wed, 13 May 2020 21:08:31 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 070712A0AFD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1589418511; bh=FhTyE8LWuX6WlUGlMBeaYWjm/Q1NP7kLXF6iw65/YUE=; h=Date:From:To:Message-ID:MIME-Version; b=Q5YZfBJ+RY1XLpTQiFg3WBXlkuI7kqbsXv4KEXiwRysh+65CoVBhmLwBaQLSDM9Y+ Ds+MwRXP+kijGe6izH0ccRPLFSydqb7gp2PKcT4b0tU8e78Ru3jAKpZ35BhvoJ+d7u LzbbLoHmHRaBQ14Pp/OxN2HX29dHQuC2R9+xWKvsHMKT7/8ufZFOzgscOrHGpaooGQ I0oNuxlCBWtL3YYpZS2U4wFWZlbQwGN3hGuIQbYCBBGpA571l9yVzap3IrsWL/rEWh wTb4aSdxhQ9x8g+YS/Yp6LOKAB53k5x+skpMmN+ckPU5WuDAOlF2M1WX7/FRHJ8jSy OWTWFj5D3yYKw== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LYmx08q-egiW; Wed, 13 May 2020 21:08:30 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id E89922A0DC8; Wed, 13 May 2020 21:08:30 -0400 (EDT) Date: Wed, 13 May 2020 21:08:30 -0400 (EDT) From: Mathieu Desnoyers To: Thomas Gleixner Cc: linux-kernel , x86 , paulmck , Andy Lutomirski , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , rostedt , "Joel Fernandes, Google" , Boris Ostrovsky , Juergen Gross , Brian Gerst , Josh Poimboeuf , Will Deacon Message-ID: <1632906547.20622.1589418510940.JavaMail.zimbra@efficios.com> In-Reply-To: <20200505134904.457578656@linutronix.de> References: <20200505134354.774943181@linutronix.de> <20200505134904.457578656@linutronix.de> Subject: Re: [patch V4 part 3 12/29] x86/entry/common: Provide idtentry_enter/exit() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_3928 (ZimbraWebClient - FF76 (Linux)/8.8.15_GA_3928) Thread-Topic: x86/entry/common: Provide idtentry_enter/exit() Thread-Index: ahehOQ76BIksR60DdD3qyNZdEVq5mQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On May 5, 2020, at 9:44 AM, Thomas Gleixner tglx@linutronix.de wrote: [...] > + * Invokes: > + * - lockdep irqflag state tracking as low level ASM entry disabled > + * interrupts. > + * > + * - Context tracking if the exception hit user mode. > + * > + * - RCU notification if the exception hit kernel mode Nit: missing "." at end of line. > + * > + * - The hardirq tracer to keep the state consistent as low level ASM > + * entry disabled interrupts. > + * This needs to be done very carefully. > + * idtentry_enter() invoked rcu_irq_enter(). This > + * needs to undone before scheduling. Nit: "to undone" -> "to be undone". Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com