Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp984309ybk; Wed, 13 May 2020 19:26:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZZIsJRmLa+RIt7e7/52SjjuehqO/C+pPL8hXB3dHWg/GgRiTryuBdEmnANhuD40XygblT X-Received: by 2002:aa7:c1c5:: with SMTP id d5mr1975626edp.183.1589423196629; Wed, 13 May 2020 19:26:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589423196; cv=none; d=google.com; s=arc-20160816; b=lJBTuoxXmdODruylxWcplN/3iazn9ghqBQFaC/TChOCftmCqu+DBnI8CikUAhNxuEk fjtSmABrfBFUMps+VZLPs9TFV212CKqaA7dI2vZvu0xOqav6Py3809+kqzHXrnsnB4OS N9h3y6piisQhIrgFkjMxcKNQB26l4x1g28/fOH+zPDYPYbTSapHVwBboNbzgdp/pspHf 21DHf46BQGU85PorEKlfQRyCCop3O2fKi+gRxnzmeeGhKGKWA9DCHK3tC4uIVDyRxzlC sKvWkBxCpGkowe7HegP5yl4V3L858ZrPKoYmTHJrM78FDY8uZiD0c/P1Z4OAH7c2DIIZ IjBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=PnLCNI/0PRbiSzNl/3JrLcx/c1BR6ToGCja7uf/ltj4=; b=xVzMKokaEkBfz/t1LMaed7nV8515L7vL1+Ehfg3bDKBdKMhrrVPtOPEpyWcvP8cRp+ yilFyZvRyxH4WW5SEWnRu9RCYJOpktpjrzu8tIpQ5gRWmYyRDQvfTwkHGMPCUcMDZq80 RA2tiOZbx6ENUZ+Mva+euSIOuPWPX5A8JrXbHVGf79GAH408crkMh/cPrJlg2Rbq1yks NOqcn3VkryHWuVLMThoZfKc3QkWND6EwetauQlcQGJ3YLr4daQsg8Wf8aqA5UB3EXZ5c QTw1MNig8rYSSogU4gWqWOau31R2f4k6V2ZewdwqldN5j9bC90Jw+eaFQSJCuL9coPWq 2xFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=id1EXOEF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l15si960155ejr.90.2020.05.13.19.26.13; Wed, 13 May 2020 19:26:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=id1EXOEF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726027AbgENCYM (ORCPT + 99 others); Wed, 13 May 2020 22:24:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:37092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgENCYM (ORCPT ); Wed, 13 May 2020 22:24:12 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B9DB205CB; Thu, 14 May 2020 02:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589423051; bh=UVerhlpWBnLUUTLMgvH5z644AkRhrk9PQ0XJpWm7g8M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=id1EXOEFsd9NC1A7aiFHA4gSUodqeY9yIpipJA6+7ELcRpMpRB/0ELix/ATkp7ZYI uj/3MThBJaNdh/tCdE9dQXzNGxGaifQDvK/jm4mvju7sX15Fr+uQHHwhdFMr93qak1 4meo2CK7yOV361bnxPMBb/8OGWnWGNJZmdtAfK1c= Date: Wed, 13 May 2020 19:24:10 -0700 From: Andrew Morton To: Johannes Weiner Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Linus Torvalds , Al Viro , kernel-team@fb.com Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU Message-Id: <20200513192410.157747af4dee2da5aa0a50b1@linux-foundation.org> In-Reply-To: <20200512212936.GA450429@cmpxchg.org> References: <20200211175507.178100-1-hannes@cmpxchg.org> <20200512212936.GA450429@cmpxchg.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 May 2020 17:29:36 -0400 Johannes Weiner wrote: > + inode_pages_clear(mapping->inode); > + else if (populated == 1) > + inode_pages_set(mapping->inode); mapping->host... I have to assume this version wasn't runtime tested, so I'll drop it.