Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Tang Bin <tangbin@cmss.chinamobile.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH v2] USB: host: ehci-mxc: Add error handling in
 ehci_mxc_drv_probe()
Thread-Topic: [PATCH v2] USB: host: ehci-mxc: Add error handling in
 ehci_mxc_drv_probe()
Thread-Index: AQHWKSoqHwlWXc5HRUSHh26WGa8dzqim4vkA
Date:   Thu, 14 May 2020 02:51:44 +0000
Message-ID: <20200514025206.GB20346@b29397-desktop>
References: <20200513132647.5456-1-tangbin@cmss.chinamobile.com>
In-Reply-To: <20200513132647.5456-1-tangbin@cmss.chinamobile.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C724AFC661FD35499D3D8AF10E7D0AE1@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f1f68066-0a3c-4517-6068-08d7f7b1bcc6
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2020 02:51:44.3259
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rEe+J5zWar11OqVaUjwkluDzzY8MhYmATWOqwvoL9FOV1TpLKm/wBVXuFMG5OFGhAY3gLyl7ZzYcbaEgyOxKbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6920
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-05-13 21:26:47, Tang Bin wrote:
> The function ehci_mxc_drv_probe() does not perform sufficient error
> checking after executing platform_get_irq(), thus fix it.
>=20
> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards=
")
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> Changes from v1
>  - fix the subject.
> ---
>  drivers/usb/host/ehci-mxc.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index c9f91e6c7..7f65c8604 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *p=
dev)
>  	}
> =20
>  	irq =3D platform_get_irq(pdev, 0);
> +	if (irq < 0)
> +		return irq;
> =20
>  	hcd =3D usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev));
>  	if (!hcd)
> --=20

Reviewed-by: Peter Chen <peter.chen@nxp.com>

--=20

Thanks,
Peter Chen=