Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1044303ybk; Wed, 13 May 2020 21:47:17 -0700 (PDT) X-Google-Smtp-Source: APiQypI6q+rxRe9Dze1uLA41B7seL/ERkgzCE2dYksrJZQ1YOcgTiqLApRCqO1XAgWOZDPz1YwTJ X-Received: by 2002:a1c:98c9:: with SMTP id a192mr24411642wme.48.1589431637003; Wed, 13 May 2020 21:47:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589431636; cv=none; d=google.com; s=arc-20160816; b=zM5iqeswBBBAGCs1ol1AyXL8d9XU2VKRMqmzV4CQLP21sSUKEPSJ9O8Mazm/BHpCs8 RzKfAI7vI5tMMj0C56x8DqqY5UQTOn4mV+dac4XwMmb/jGm49uH+WpiIcuHTF1KpeQAV W0vcB4nNoY7VSCWaOx0OjEg2Ur3mwqq05Xv1XfF3w5qLa6UYGD4dngN9BYpKG342eTDc axiH58Dh0GVHh3SFLmnqTyqGhmpwmEYZ1f9d4hbS8RgBwuCXZzDTtFUKqIzvbAGWUNgr dnZuZPwKsh/7bx1HenLtQquFYUHoZK+QL95ovl3Oi5yavXRwFK0Hlc1mSfKT6XN0NQYH 6IVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=6FWhNnoPHUiXRSobYeVP33F7TLEdXOhLvkVv2GgksQE=; b=IyxlIvcsep9F5mPuQa3rZhTg8sKxUtkNUfpnJQjBrCZU9gacMW2FFJeL5F17zx4o9O 2Skaqqat60H5LcYoW8unGAVco14XNQ+EDHTSefLKUKaNqPkVK6P+enZYef5zehbK5T7P 3zYFDvfwXkfQh9/N7NdWL25BKW++oLPvqE+5fXRTWRUZfGtd1CnFR0f89vgLMjakLiAI CMH7/G29ggZqPdtXjN3oxaOEuhbBgScZnJXmU+WO00b/QpuVZfOHQ+RU0YHC661C7uRP +uGPrNfqEid7z8AOFlE80gKlWMfH1jGQpU/2U3RBG7D940CxAb/YJ9J26Ypryh+5/e+0 HWuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eq5eOFj+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si943518eds.403.2020.05.13.21.46.53; Wed, 13 May 2020 21:47:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eq5eOFj+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725926AbgENEpQ (ORCPT + 99 others); Thu, 14 May 2020 00:45:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:60980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbgENEpP (ORCPT ); Thu, 14 May 2020 00:45:15 -0400 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C625C20575 for ; Thu, 14 May 2020 04:45:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589431515; bh=LtPFqQjRPKDJYUvUcsyFImgf0124qc1+JjNISUKgkbw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Eq5eOFj+Etf6Mu2aUm13O6bWOylqegWaS8A4mVXH30kLP+QRqltUWNRMDg7XghiKQ PZU/sViBOG+xikAg/y81V1lFvAh7ZLg2zFlZm+ogiaQL1VYFyJqbCatLL3g5a9S5Rv gjX7n7FH00hvin2LsVCXYIrekAKOka5rFr2TTwbY= Received: by mail-wm1-f50.google.com with SMTP id h4so28759355wmb.4 for ; Wed, 13 May 2020 21:45:14 -0700 (PDT) X-Gm-Message-State: AGi0PuaKnyYA1VVokac0lSLQmpIiXAysJ94W/KnjbVI0KwQSpPRCv8// 2LIH1oygwAauFJcBwdr4/c/II/g1p0zlOL7BtyLY0w== X-Received: by 2002:a7b:c5d3:: with SMTP id n19mr39164430wmk.21.1589431513225; Wed, 13 May 2020 21:45:13 -0700 (PDT) MIME-Version: 1.0 References: <20200505134354.774943181@linutronix.de> <20200505134904.955511913@linutronix.de> In-Reply-To: <20200505134904.955511913@linutronix.de> From: Andy Lutomirski Date: Wed, 13 May 2020 21:45:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch V4 part 3 17/29] x86/entry: Convert Invalid Opcode exception to IDTENTRY To: Thomas Gleixner Cc: LKML , X86 ML , "Paul E. McKenney" , Andy Lutomirski , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Boris Ostrovsky , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Josh Poimboeuf , Will Deacon Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 5, 2020 at 7:15 AM Thomas Gleixner wrote: > > From: Thomas Gleixner > > Convert #UD to IDTENTRY: > - Implement the C entry point with DEFINE_IDTENTRY > - Emit the ASM stub with DECLARE_IDTENTRY > - Remove the ASM idtentry in 64bit > - Remove the open coded ASM entry code in 32bit > - Fixup the XEN/PV code > - Fixup the FOOF bug call in fault.c > - Remove the old prototyoes > > No functional change. I think there *is* a functional change: > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -567,7 +567,7 @@ static int is_f00f_bug(struct pt_regs *r > nr = (address - idt_descr.address) >> 3; > > if (nr == 6) { > - do_invalid_op(regs, 0); > + handle_invalid_op(regs); I suspect the old code was wrong and no one noticed because no one has a F00F-buggy machine any more. So maybe document that you fixed up the F00F bug, too. Otherwise: Acked-by: Andy Lutomirski