Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 6FtP6rZlKTVvoaS/Iv6G288xQx+lp5U0/QYuc0ryCZ39qVXdk4bBRFh9G3WP/heV2RMcpg8TiF
 1CqVBpaGHCKA==
IronPort-SDR: pjpswNHL1LItcqQqR0fzRL65fOpKrj/ga7S2zR7VS3eQ4cbekctr5P9OPZKMt9jqWnx6CAQmMF
 3w8qJ9IVCRXQ==
From:   "Wu, Hao" <hao.wu@intel.com>
To:     Souptick Joarder <jrdr.linux@gmail.com>
CC:     "mdf@kernel.org" <mdf@kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Xu, Yilun" <yilun.xu@intel.com>
Subject: RE: [PATCH] fpga: dfl: afu: Corrected error handling levels
Thread-Topic: [PATCH] fpga: dfl: afu: Corrected error handling levels
Thread-Index: AQHWKVq9Jcnvngz3AkiOgohHnshzdKim3E6AgAA7lpA=
Date:   Thu, 14 May 2020 06:06:13 +0000
Message-ID: <DM6PR11MB38193B495FB1DB4697F0094F85BC0@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <1589397725-29697-1-git-send-email-jrdr.linux@gmail.com>
 <20200514022935.GE29933@yilunxu-OptiPlex-7050>
In-Reply-To: <20200514022935.GE29933@yilunxu-OptiPlex-7050>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9258c4c2-9c30-44a3-9db4-08d7f7cce828
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2020 06:06:13.5260
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yAqGcX9yhxbq5CKWeKOAMoJbM95UA+eUo0Mnl38Qz+ZuzBdcsGTM2ybAsG0wUQRVR/ymkYsYkmYS4ne8nNwj8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3627
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Xu, Yilun <yilun.xu@intel.com>
> Sent: Thursday, May 14, 2020 10:30 AM
> To: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: Wu, Hao <hao.wu@intel.com>; mdf@kernel.org; linux-
> fpga@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] fpga: dfl: afu: Corrected error handling levels
>=20
> The patch looks good to me.
>=20
> Maybe we could add the Fixes tag:
>   Fixes: fa8dda1edef9 (fpga: dfl: afu: add
> DFL_FPGA_PORT_DMA_MAP/UNMAP ioctls support)

Thanks for catching this problem.

With this line,
Acked-by: Wu Hao <hao.wu@intel.com>

Thanks!
Hao

>=20
> Thanks,
> Yilun
>=20
> On Thu, May 14, 2020 at 12:52:05AM +0530, Souptick Joarder wrote:
> > Corrected error handling goto sequnece. Level put_pages should
> > be called when pinned pages >=3D 0 && pinned !=3D npages. Level
> > free_pages should be called when pinned pages < 0.
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > ---
> >  drivers/fpga/dfl-afu-dma-region.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fpga/dfl-afu-dma-region.c b/drivers/fpga/dfl-afu-d=
ma-
> region.c
> > index 62f9244..5942343 100644
> > --- a/drivers/fpga/dfl-afu-dma-region.c
> > +++ b/drivers/fpga/dfl-afu-dma-region.c
> > @@ -61,10 +61,10 @@ static int afu_dma_pin_pages(struct
> dfl_feature_platform_data *pdata,
> >  				     region->pages);
> >  	if (pinned < 0) {
> >  		ret =3D pinned;
> > -		goto put_pages;
> > +		goto free_pages;
> >  	} else if (pinned !=3D npages) {
> >  		ret =3D -EFAULT;
> > -		goto free_pages;
> > +		goto put_pages;
> >  	}
> >
> >  	dev_dbg(dev, "%d pages pinned\n", pinned);
> > --
> > 1.9.1