Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1132696ybk; Thu, 14 May 2020 01:00:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYnCZZXUGBJpE4Jai2W8BYj3ii5/yaIYbyFiqLwCUpbyyzB2u9hyQBhvjSRaL1N4xWD0qm X-Received: by 2002:a17:906:70c2:: with SMTP id g2mr80595ejk.207.1589443239214; Thu, 14 May 2020 01:00:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589443239; cv=none; d=google.com; s=arc-20160816; b=l44w2Xig73goWMFTtluXbb2ehmYmsLxRHbw1AbIzKCdvb2rYGelWSgzeehZu5EaVVc s7XXEZ8cz989nqySD6llEnGuOqkkjSioOwpdtLmpXXjOz5DUb9TRvfJ+2rrOX6SGl6Pm 7E0sAneOEqKuiFr2pjkHpErhFN7vM29wvgaAYmCX/aF7bBO8a++pReagsmlqyC1bqz8Y ldDnEfqdRdbJ83Lh5qKylQgByrRiyqPaHRzTT2q7jRJFsHrhqGxX6UsiTFd6tu8A6mfT pHTQr+tD8nf74jdThcy3jSXra5XpdFQp4rQzgjZPGPDOY9sGE0bmdzxcoVC9Guetqgr1 89Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=3LScCgI1Um5zKxT72NsH3m/gAN20byR4CLshXl2giDE=; b=zdEB41fi0IpNbbQ1g1ZN6jCEc/VTuyE6/KIMKtDUOca5f/JfhJu8MFa5po1Lqv0tOV 2iI8WGtUqBpHwzMKFxfdLsJZSAT3msPQcv5wMgc6ZAgF2yrAon16hTHsQ5oJ1W4hldh5 ZFeN6BL7uIj9PNj7S+pXgNB85eQb+VmljHGFTEEJcSLiA+bY6BN3MdvFP50/4Kd0VEvN BfOthaCWnpojBRxE02z1xuf20qVCz3q2GG6DZMhKW6ih+WjCiDRJsjARTKs3lscmm/e1 2ekCuOPqV1ieuXkK68GnpPFxrYC5Ich6VlTSKwPr8gjIcXbxAI94X8Ngf6zmHivo4Mdh dkUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si1458046ejr.380.2020.05.14.01.00.16; Thu, 14 May 2020 01:00:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbgENH5f (ORCPT + 99 others); Thu, 14 May 2020 03:57:35 -0400 Received: from elvis.franken.de ([193.175.24.41]:53047 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725952AbgENH5K (ORCPT ); Thu, 14 May 2020 03:57:10 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jZ8js-0005U5-05; Thu, 14 May 2020 09:57:08 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C4A2BC0493; Thu, 14 May 2020 09:49:16 +0200 (CEST) Date: Thu, 14 May 2020 09:49:16 +0200 From: Thomas Bogendoerfer To: Emil Velikov Cc: dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 05/11] MIPS: constify sysrq_key_op Message-ID: <20200514074916.GF5880@alpha.franken.de> References: <20200513214351.2138580-1-emil.l.velikov@gmail.com> <20200513214351.2138580-5-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513214351.2138580-5-emil.l.velikov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 10:43:45PM +0100, Emil Velikov wrote: > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-kernel@vger.kernel.org > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > Signed-off-by: Emil Velikov > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better it this gets merged this via the tty tree. > --- > arch/mips/kernel/sysrq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thomas Bogendoerfer Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]