Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1134045ybk; Thu, 14 May 2020 01:02:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM3vgZ7yZAlfdNHkC6yz99BB25+LEzLAxTD7GxW8RepBmnnJHETuX4NFM8sg4krdRotEH9 X-Received: by 2002:aa7:d894:: with SMTP id u20mr2644545edq.205.1589443340525; Thu, 14 May 2020 01:02:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589443340; cv=none; d=google.com; s=arc-20160816; b=UiDULmowboUS4AwoSgWFyRtxCwIJZZ3jpv5hvQxzHp+QIUpteZSc2YuKrIHQbfkGJA FRJhxNFtOg0BHKfMTsCz7LPtGQsKqxDJMBlQxkRrs3nNZ8Ak0NR7a1Hn1cuQ3/QnI31l m4m0So3fXpQTQtKn76CCoRoXQQRL8LQ/ihsIX40i5hpwU0j091H97pIuvZxRS7T7p5tN kzOkOOGrfPIyjFzqUi51x5TsIX+ofinRUwAVkHZpo1I5AQW1Bvm/j1qGeWQLgHkYUL3Z CH/3TMPsGVTUPL9qbJ6IOaD+45JRc7tWetzdavr1643MbvBnskUwHprikQFKN4gOWax2 fKsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=e4jjCqMhrz73017AHqU+ojMzDyx024B7mYUCVLrg2XA=; b=nfOJo6Zd13ei4Dkt+qNdGj7xAIZeXg5/LzhjArHJw4zejTfH6gJ0V7HFkJgJvmNveV UF2rrE6lzcjo18T7n53A7pwUfW8qSz3G8VmuvV6U7O5C2KQfMGNm6Ooz/O9mc6ue0Iwi 8cQ/sDXM7uak6JR+RfDqsUSHUR6IYZzznpxg3ADjyFurDtpFOSRkS1/snCZhXBqgjc9B psGOP1lb8e8yVvkF54QibrLTwE6DjdWwAhatYMjZHIbhM6N6J+eH4MeyjK2auajK5cxu gotC1aXvZh0BN1lvEAQADWjmpH8fcQWbJX2JHx+BAgiKljSbB13cdsLsqmfePH4R5xnr Ffhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EnRhIpz7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si1382289eje.518.2020.05.14.01.01.57; Thu, 14 May 2020 01:02:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EnRhIpz7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726015AbgENIAE (ORCPT + 99 others); Thu, 14 May 2020 04:00:04 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41222 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725952AbgENIAE (ORCPT ); Thu, 14 May 2020 04:00:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589443203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e4jjCqMhrz73017AHqU+ojMzDyx024B7mYUCVLrg2XA=; b=EnRhIpz76HdOVmzPhyaDfrZy0InWXAgfZimbjbW6G1H3JSqxry3ShJ+H4mB02mhMMro/O2 zRipUrdV6njafFwbcdwaEpkLPr6pyhiLagp4n+O4uJROwT1fPUSujc6l7gCJzQfDA7FA3e jrcg2cDv6w6j4Eu4Fly0o70G23wC4tY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-DblcYXPVPo60onW8Liue0g-1; Thu, 14 May 2020 03:59:59 -0400 X-MC-Unique: DblcYXPVPo60onW8Liue0g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 80E5180058A; Thu, 14 May 2020 07:59:57 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-115-145.ams2.redhat.com [10.36.115.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3CF086A977; Thu, 14 May 2020 07:59:53 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6FE4417444; Thu, 14 May 2020 09:59:52 +0200 (CEST) Date: Thu, 14 May 2020 09:59:52 +0200 From: Gerd Hoffmann To: Daniel Vetter Cc: David Stevens , Tomasz Figa , David Airlie , "Michael S . Tsirkin" , Jason Wang , Sumit Semwal , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Linux Kernel Mailing List , dri-devel , "open list:VIRTIO CORE, NET..." , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" , virtio-dev@lists.oasis-open.org Subject: Re: [PATCH v3 1/4] dma-buf: add support for virtio exported objects Message-ID: <20200514075952.zuc3zjtmasaqrw75@sirius.home.kraxel.org> References: <20200311112004.47138-1-stevensd@chromium.org> <20200311112004.47138-2-stevensd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > - for the runtime upcasting the usual approach is to check the ->ops > pointer. Which means that would need to be the same for all virtio > dma_bufs, which might get a bit awkward. But I'd really prefer we not > add allocator specific stuff like this to dma-buf. This is exactly the problem, it gets messy quickly, also when it comes to using the drm_prime.c helpers ... take care, Gerd