Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0Y3Pv7UCp3mAT5TEROn3U+48T2Mv/N55yt1fR9rJQRmJlK/PMkWzNEGKvJysBdH929zw56q+Jy
 N7QO8c+FdD2bF5b7dpsE62No91JOJpywRYEMMESqLi2y1RQ90MnAKtCckp4RBFCTA7ttAepP5/
 0bAwdvgvngpCTIr7RzS0YSFqJAVJ3M/VnXbs4vJW0yjhm2D7k24LETC3/qvfRVQ9MVTTl4Phfh
 SQcT8z4jiQSK6sfC+bQVbgvZhoNFCRFXCepH8H0QdPtKWRc2D2Xd3gJUEqERAsMM7B2xGFEzFz
 IRg=
Date:   Thu, 14 May 2020 10:09:23 +0200
From:   Ricard Wanderlof <ricardw@axis.com>
To:     Dan Murphy <dmurphy@ti.com>
CC:     "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>, Rob Herring <robh@kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] ASoC: tlv320adcx140: Add device tree property
 for PDM edges
In-Reply-To: <20200513200549.12213-2-dmurphy@ti.com>
Message-ID: <alpine.DEB.2.20.2005141006450.30387@lnxricardw1.se.axis.com>
References: <20200513200549.12213-1-dmurphy@ti.com> <20200513200549.12213-2-dmurphy@ti.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Wed, 13 May 2020, Dan Murphy wrote:

> Add a device tree property to configure the PDM sampling edge for each
> digital microphone.
> 
> CC: Rob Herring <robh@kernel.org>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> ?.../devicetree/bindings/sound/tlv320adcx140.yaml?? | 14 ++++++++++++++
> ?1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> index ab2268c0ee67..55668c7d261d 100644
> --- a/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> +++ b/Documentation/devicetree/bindings/sound/tlv320adcx140.yaml
> @@ -63,6 +63,19 @@ properties:
> ?????? - $ref: /schemas/types.yaml#/definitions/uint32
> ?????? - enum: [0, 1, 2]
> ?
> +? ti,pdm-edge-select:
> +??? description: |
> +?????? Defines the sampling edge configuration for the PDM inputs.? This is
> an
> +?????? array defined as <PDMIN1 PDMIN2 PDMIN3 PDMIN4>. 0 (default) is
> negative
> +?????? sampling edge and 1 is positive sampling edge.

A bit of a nitpick, but I would think of the edges as 
negative-going/positive-going, or rising/falling. Not sure if anyone would 
misunderstand 'negative edge' in practice though.

> +??? allOf:
> +????? - $ref: /schemas/types.yaml#/definitions/uint32-array
> +????? - minItems: 1
> +??????? maxItems: 4
> +??????? items:
> +????????? maximum: 1
> +??????? default: [0, 0, 0, 0]
> +
> ?required:
> ?? - compatible
> ?? - reg
> @@ -77,6 +90,7 @@ examples:
> ???????? compatible = "ti,tlv320adc5140";
> ???????? reg = <0x4c>;
> ???????? ti,mic-bias-source = <6>;
> +??????? ti,pdm-edge-select = < 0 1 0 1>;

Should there really be a space between < and 0 ?

/Ricard
-- 
Ricard Wolf Wanderlof                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30