Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1155440ybk; Thu, 14 May 2020 01:43:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcQb3n/B9Lso/Arpxg4Q2aBuRcjvEokEOEkMQitHQZyh9dPQRWpN9mjjm0u4VKF30un2Oo X-Received: by 2002:a17:906:5615:: with SMTP id f21mr1162830ejq.372.1589445797727; Thu, 14 May 2020 01:43:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589445797; cv=none; d=google.com; s=arc-20160816; b=iZTGbopt3kPotpOtjOMwuUJFUB74RY8KD8/GT3JNyNoqfLmLWUqeGFZtij0Cu7be5x b3jE3q28UxeKub9Rms8sIdtUXhjKVTO1kYZoH/GzabmIFbvLerU0gQU10V5DU/I6PDaV YJzqLp1wX2YBwjuGcJMQM5qZOvJeiDCWw98uNkhTq7hmI5Od39RU//ivX+7km+pVDFQS y8WozVDciZx0VqDzd/voWQUgc05ATK9H9EOBneBH5NA71Xpe1jmIV7zEhOhCmUH2ZxDt 482LEUev18dlQBlip2p+3UbeLlx+r4m++OSkg1vH+OPujKTAlV67gi1sBF3CdvudZz2l KbJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=W+XqwaC/TVRiz8d091PLNuRgkQiXrI8h2KPeOiIlVes=; b=rphyWp1R0OvRHltmci7jGqFJWW4Ip1/Ce3tIe1NqJ0L7f4Kjiokk2an9yVg3d+g5G+ 1GzSckKGVamuK/nZofqWGDmFXalE2VGfMWZNcJ6FaOqkrb0RGDmTegwK/Qap3zL7YS9Y djhG1OspJxwvOIIhHmWdALhanAbeE+1Oja2dIZqQVfPUwroEGchULyopqiaqEWIc4tyc tt5KQ0T8wRAF9waL9efihxsKRdidX0Lb1ei1+W1NIU+llhy3ivBLBmWsvRqvYcYWbeJJ r4Ep/H8Zf/o9PUheOkeE9EpHx5f2mBtYVhhVadz5jkBz+uLgBebwcBk+lDdzNkYFL7+3 fVjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by25si1371003ejb.413.2020.05.14.01.42.55; Thu, 14 May 2020 01:43:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726117AbgENIjk (ORCPT + 99 others); Thu, 14 May 2020 04:39:40 -0400 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:7709 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725946AbgENIjk (ORCPT ); Thu, 14 May 2020 04:39:40 -0400 Received: from sc9-mailhost2.vmware.com (10.113.161.72) by EX13-EDG-OU-001.vmware.com (10.113.208.155) with Microsoft SMTP Server id 15.0.1156.6; Thu, 14 May 2020 01:39:35 -0700 Received: from [0.0.0.0] (oddjob.vmware.com [10.253.4.32]) by sc9-mailhost2.vmware.com (Postfix) with ESMTP id 24D28B2723; Thu, 14 May 2020 04:39:35 -0400 (EDT) Subject: Re: [Linux-graphics-maintainer] [PATCH] drm/vmwgfx: Return true in function vmw_fence_obj_signaled() To: Jason Yan , , , , , , , , , , References: <20200507110714.37589-1-yanaijie@huawei.com> From: Roland Scheidegger Message-ID: <0b30cc20-95d4-009b-6c77-f1119d396e8b@vmware.com> Date: Thu, 14 May 2020 10:39:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20200507110714.37589-1-yanaijie@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: de-DE Content-Transfer-Encoding: 7bit Received-SPF: None (EX13-EDG-OU-001.vmware.com: sroland@vmware.com does not designate permitted sender hosts) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've pulled that into our tree, thanks! Roland Am 07.05.20 um 13:07 schrieb Jason Yan: > Fix the following coccicheck warning: > > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:518:9-10: WARNING: return of 0/1 > in function 'vmw_fence_obj_signaled' with return type bool > > Signed-off-by: Jason Yan > --- > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > index 178a6cd1a06f..0f8d29397157 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > @@ -515,7 +515,7 @@ bool vmw_fence_obj_signaled(struct vmw_fence_obj *fence) > struct vmw_fence_manager *fman = fman_from_fence(fence); > > if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->base.flags)) > - return 1; > + return true; > > vmw_fences_update(fman); > >