Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1223094ybk; Thu, 14 May 2020 03:42:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzb8MEXfJbyyfL8C3GZ6idAfVHB08lwpVWK676JyV8Me+bW0G3S0Ttep1lRB09mP1XOvcxD X-Received: by 2002:a17:906:8402:: with SMTP id n2mr3197858ejx.26.1589452950465; Thu, 14 May 2020 03:42:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589452950; cv=none; d=google.com; s=arc-20160816; b=fI9fVKmvIoJW6h98870PUmmewmOd8gZphqUN6DGe/sB3dBGEaQps+dISakAb0Yu65Y wnPFx3lMTlr2dOi2Ra4NUK0cnC0lMV2uEfxgWendrjQbMR3QiwETBv3Yo7YCaLG2BWcf Qfgp0IculOH3nvz50/ClUuzbD/FU0fsanfQKA7h6ZzS9/sKVyj5NUFC1PNsTCVMzkL0u OtezrTrz+7vOfwAwjvUBMRndkadBD/vmP+RX/yuJEXr5uQt7w3W+IEjBdncxt2Fa0mMu 0MtbcKtEFrbe4OugJnXbv4xobcTDLW+Kw4icIMc29aH9dhdpOUui5M5xomgMTJhpivBk veoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=oQGuvng4zGGv5wxqMi1jZPorRLuXoaTainTjhtEgYIQ=; b=Wf6e/Hpk+lc4w9CR10a43CJ9z9KgSwJqiLgU7SOb2aaTVOelhF8Xo4AV7xEtNWsDah hU06uctpP09HFCHk2IyJt4O036lQdacNUX0c+IeH05Gg+xvTEl+7FZ7lkRQYHkWzar9s 0gDHHBy9J1l/szRADgJ1PpzmzwFFaslkd389Yd1SYganYVRpGmoUTSBGfBGPd8x1Otnq NW1FwNdwZ4m9SjQ1T0o76bv0UKeVh+9pQ7FHtYEfoDGfteHkBCTpO/EoV0JMp2IVIlzT CB5uk59lVtqTjZMXt/sNeg5lFehwiy5Nv9vf8RxbyWFOjYcdm0bCIS6GnftFQIPGLRV0 Jh5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=lPkCbxeM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si1305350edn.296.2020.05.14.03.42.07; Thu, 14 May 2020 03:42:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=lPkCbxeM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbgENKhm (ORCPT + 99 others); Thu, 14 May 2020 06:37:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726056AbgENKhm (ORCPT ); Thu, 14 May 2020 06:37:42 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC82C061A0E for ; Thu, 14 May 2020 03:37:40 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id x12so2378975qts.9 for ; Thu, 14 May 2020 03:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oQGuvng4zGGv5wxqMi1jZPorRLuXoaTainTjhtEgYIQ=; b=lPkCbxeMo7dsvFXTJg0O7IFp8a4XUMtflfpaw4jJsj34jpWrE7nR4OtRrG/OHB1V8j clSkW03wJM/LcoIo9aLEGmLWH5MymBRcWQng8UEd1YI0Qc0DLfhVql6UETwJUUq0M4UZ I68gS+DIMYU1xqH1eGpRsXq9Sda4RI4fmrq3d1y7myiVHD6sNyUenFBS7XucShvteUqh FWQuIcCzrqANHmgxDtH8lnnj/BWq2BPEqKQ5qiTVoP0wchnJCkH8GCZUysQ4E4jqX0UQ PDaqJnZeKrdM92YNItffMp9M5t4VvaA7UFTrODdfaQ2xaH8t9lOpsi/+tnsv7QnXlsCc ySBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oQGuvng4zGGv5wxqMi1jZPorRLuXoaTainTjhtEgYIQ=; b=jzqCAXZLzZRT/n6NLqLbuq9zP9LYV12xe2xftGexT3o9jUxrS0XiGdWpAy4D8A56o8 uKsAd8A2ltazfsVJojmxK1HwBTtLV4CeeLRui1zrvZivGmHOpeNH9Gb3mTlAWcWABK0K /gIkXYwzTqTLrNf0u9DP83fmt2UpcXwOLcMhaPEwlWDREKFyNVlLHzZgkpquK2hxI02f 2OUt5KrxJiQj2PMhSuMZ7UL/DkA51LCOm1oh6Ze24klLfd7JOAZXzy8sXtvwfWMOMOud CSTTN/EtmRAo7XxY4+L1BV/dRhDpkhykuzv4gVjAHxpGPU/pPVvEurwhQ4llV1fy1GN3 YXbw== X-Gm-Message-State: AOAM533zcRsYlAq6ZDI9hDEWTg+fz9dI4YZaXvC13mgFforLp5ek72RE 9csxg1xzaST1AaTXpnIQanbRCA== X-Received: by 2002:ac8:6055:: with SMTP id k21mr2150455qtm.294.1589452659861; Thu, 14 May 2020 03:37:39 -0700 (PDT) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id h3sm2346327qkf.15.2020.05.14.03.37.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2020 03:37:39 -0700 (PDT) Date: Thu, 14 May 2020 06:37:20 -0400 From: Johannes Weiner To: Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Linus Torvalds , Al Viro , kernel-team@fb.com Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU Message-ID: <20200514103720.GA544269@cmpxchg.org> References: <20200211175507.178100-1-hannes@cmpxchg.org> <20200512212936.GA450429@cmpxchg.org> <20200513192410.157747af4dee2da5aa0a50b1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513192410.157747af4dee2da5aa0a50b1@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 07:24:10PM -0700, Andrew Morton wrote: > On Tue, 12 May 2020 17:29:36 -0400 Johannes Weiner wrote: > > > + inode_pages_clear(mapping->inode); > > + else if (populated == 1) > > + inode_pages_set(mapping->inode); > > mapping->host... I'll fix that. > I have to assume this version wasn't runtime tested, so I'll drop it. It was, but I don't have DAX-suitable hardware so that config option isn't enabled anywhere. I'll try to test this with a brd. Sorry about that.