Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1247006ybk; Thu, 14 May 2020 04:22:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFTtXGCYY6X0ID1YtT1VHAQpSqfHcnnuvZj1t3bHOL/0SJ88tqVoLjNBAFIEgrjH9AqqYO X-Received: by 2002:a17:906:2296:: with SMTP id p22mr3217008eja.269.1589455371444; Thu, 14 May 2020 04:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589455371; cv=none; d=google.com; s=arc-20160816; b=M6zSvNp8562tKo+/FwmVYP/JVVcMYAEoD2+CRW9KYJKTeidOdnh1NRsrHWBKAlLun2 7g5LtPQQU7LIV+Lgv3ne3l7NvP9EBUvlJk2h/GI/C4NgSZVItGvHjs8bE0TTc74/g18M bf6Oafdaq3lTpJseh5ga/eY+akn/div93Pb2XbzVBlCRiTDQS/xBmPVAiHpb0Cy8DLfA BcdMcBpqRIcckLkDfsI8agVzJW8qeP4R/Bxe8hISvSLO4iNwQ5h7haVfCLU/NCKSU9w0 18CeA2Kjm6xVacuAhTQoH8A+5V8fCirBWC5G+jcgCe9Ipei+ftlzdqjKhY7TfqtBzlkL xHjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=mjaEhAMukt4Q737HPM6C7TaDlquG096H0lSzCeaiEoc=; b=gvMwgFhuz9T1fZyMHG414ky9FYYQG9PTxxmuuJ9C5+tiBDXu1DIfoudUUlpjdHTtsI eDcCfKZfsRDPGlwyrShit9CTmoRs7afL5UtQTHCgACUvSgpG7Fox6jw5t+4STXLdCCK4 FnZvqR53q13MXbG3f1pp/lFg0ePnO5rzJupw1RJKCAFZxuqmMcOYBVBjm5rTCkqEyDTd f+FJbW/g9j3fyhNeVAloGvDz+PYybfwFbJg3UrBMfhcs95g7gmWTyRTM+EP+NM0Ait9V pN3mcJGlksY/b8ezCOPgHrzdjINGx6mvsxiHmv8GzgTHiuYnIE9Ols6H9GGTW6rsGvGl bQCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u29si1358738edl.329.2020.05.14.04.22.28; Thu, 14 May 2020 04:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726087AbgENLVF (ORCPT + 99 others); Thu, 14 May 2020 07:21:05 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:37575 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbgENLVF (ORCPT ); Thu, 14 May 2020 07:21:05 -0400 Received: by mail-ot1-f67.google.com with SMTP id z17so2036064oto.4; Thu, 14 May 2020 04:21:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjaEhAMukt4Q737HPM6C7TaDlquG096H0lSzCeaiEoc=; b=VGMfZMnKMmRN0cmSILvH0P4ao1gR1iQgt3cfzoBTCo29kKZA1Bo3Uisa8WNIMuD7gT qIbA3qiidb1vjWKCAlirii9q8W0nfFogmp/fr3j1dSu2mpVVcRDMg7N+5+g6jUn0ijYm YJoPHhFOYhonTtEBbBVzJysvcy9EPEIxluC4JgLfo1lm3LxB/eRda3cyJ6MGl0kr+3+H cm0jimxmbJRUj0NgJLcFGs4aehzAXD96Huh3905dRQe5p6cYAQsyCvWlEsjf2TM3HCNu GoGAQcavk/wM3wYb9sAQvyKF6W/OuVenXNGOJ6KO7B1DVCdDQWSkol+WiMCvLEZ+gixi FemQ== X-Gm-Message-State: AOAM531/QTpQ34AAhyy/lGM20zp4x/hjVFsPxeoVw9ekjbUZwy0Qk3Rp MKzJXBuXKAJl9F2ylttfEhuCs7j7ikyYeLq+yYY= X-Received: by 2002:a9d:6356:: with SMTP id y22mr2944323otk.167.1589455262888; Thu, 14 May 2020 04:21:02 -0700 (PDT) MIME-Version: 1.0 References: <20200513214351.2138580-1-emil.l.velikov@gmail.com> <20200513214351.2138580-10-emil.l.velikov@gmail.com> In-Reply-To: <20200513214351.2138580-10-emil.l.velikov@gmail.com> From: "Rafael J. Wysocki" Date: Thu, 14 May 2020 13:20:51 +0200 Message-ID: Subject: Re: [PATCH 10/11] kernel/power: constify sysrq_key_op To: Emil Velikov Cc: dri-devel , Greg Kroah-Hartman , Jiri Slaby , Linux Kernel Mailing List , "Rafael J. Wysocki" , Len Brown , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 11:46 PM Emil Velikov wrote: > > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-kernel@vger.kernel.org > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: linux-pm@vger.kernel.org > Signed-off-by: Emil Velikov Acked-by: Rafael J. Wysocki and I'm assuming that this is going to be applied along with the rest of the series. > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better if this gets merged this via the tty tree. > --- > kernel/power/poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/poweroff.c b/kernel/power/poweroff.c > index 6d475281c730..562aa0e450ed 100644 > --- a/kernel/power/poweroff.c > +++ b/kernel/power/poweroff.c > @@ -29,7 +29,7 @@ static void handle_poweroff(int key) > schedule_work_on(cpumask_first(cpu_online_mask), &poweroff_work); > } > > -static struct sysrq_key_op sysrq_poweroff_op = { > +static const struct sysrq_key_op sysrq_poweroff_op = { > .handler = handle_poweroff, > .help_msg = "poweroff(o)", > .action_msg = "Power Off", > -- > 2.25.1 >