Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1247857ybk; Thu, 14 May 2020 04:24:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDBMVY0H3PFf8lHzoQzgE73IF7oveKrqR2VABYQ7juk3lnKQvQ/bbllI4S1g37RS9pYVNH X-Received: by 2002:a50:a7e4:: with SMTP id i91mr3319996edc.381.1589455463965; Thu, 14 May 2020 04:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589455463; cv=none; d=google.com; s=arc-20160816; b=S82RQdIpf2DSzvHf0uqoSpXXzTtbQDSeofwCXLuwIJOhKOR/cme/3MlgxN0nt7+ex2 Y1rwb3nSUDfjS4U1Cfq6/W8K03tpHF3jQugX6g+3rz6C32c51ll76KhPDIjbw6fn/RYH MZ7Lqlv131Y7fnmXm8QzOb8tQizrsL/WAZRZPbnyYg++juUw2nn+MgGEHcWnFCslqWU8 EzAyz0agkHzzs+GR0VnncqL/5Ce3MoKZAq0FDX+Qd8Sz2GoZIUYs1nRJSHaThXgf89B/ 5904RQ3q7o3cBaZATb7pf4PVZDG7wSeo6W99UwWZipuDIgfb7dolhEz08+bWSfTIppWX D8Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=eyaeUqaczH9cHixE9V/ccpnbhjBYXczpU/s5n+AONfs=; b=ERaKr7AZsqE8z5d2QxelAdrokAZaVJaW5lpwIGv/XXKpbcdaTC9iqUTfm4XT22nzgX 8oQE4timAmmfBGdJu35IEB+YQIMygOaKBRqYZBOE+gEV0LAetX5f6yyIV2y1qsiS3x9t TGTodf2E6uW239qUqIfeJ52UqpNBS8CUltY07M0eWSTcN1Oa8h/jXiYDJjWaQiyb0Cpx HWHn1uv61EuD6q9yXObQemn7JWk1yZPH/qy40Egg/KoxmlEhE1WB82P6md8mIbnKWupP vzKie99ApaDcwD9ULwPcEjvUsxZdAqmAhMzPSfGbJ+N1TmTKsv/sAq7t5CXZb18B0Dyl p1DA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ba4si1345945edb.479.2020.05.14.04.24.00; Thu, 14 May 2020 04:24:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbgENLTQ (ORCPT + 99 others); Thu, 14 May 2020 07:19:16 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50570 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727885AbgENLTP (ORCPT ); Thu, 14 May 2020 07:19:15 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04EB4mDN024609; Thu, 14 May 2020 07:18:56 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 310syx06wu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 May 2020 07:18:56 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 04EB5DP0025591; Thu, 14 May 2020 07:18:55 -0400 Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 310syx06vq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 May 2020 07:18:54 -0400 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 04EBG1AL009913; Thu, 14 May 2020 11:18:51 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma04fra.de.ibm.com with ESMTP id 3100uc1e00-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 May 2020 11:18:51 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 04EBImke34013208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 May 2020 11:18:48 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C025B42041; Thu, 14 May 2020 11:18:48 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 178F74203F; Thu, 14 May 2020 11:18:45 +0000 (GMT) Received: from bangoria.ibmuc.com (unknown [9.199.59.186]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 14 May 2020 11:18:44 +0000 (GMT) From: Ravi Bangoria To: mpe@ellerman.id.au, mikey@neuling.org Cc: apopple@linux.ibm.com, paulus@samba.org, npiggin@gmail.com, christophe.leroy@c-s.fr, naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org, jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, ravi.bangoria@linux.ibm.com Subject: [PATCH v6 15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting Date: Thu, 14 May 2020 16:47:40 +0530 Message-Id: <20200514111741.97993-16-ravi.bangoria@linux.ibm.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200514111741.97993-1-ravi.bangoria@linux.ibm.com> References: <20200514111741.97993-1-ravi.bangoria@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676 definitions=2020-05-14_02:2020-05-13,2020-05-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=2 spamscore=0 bulkscore=0 impostorscore=0 cotscore=-2147483648 phishscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=891 malwarescore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005140095 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Xmon allows overwriting breakpoints because it's supported by only one DAWR. But with multiple DAWRs, overwriting becomes ambiguous or unnecessary complicated. So let's not allow it. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/xmon/xmon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 30b3e3d99c0d..094bf4715f2c 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -1399,6 +1399,10 @@ bpt_cmds(void) printf("Hardware data breakpoint not supported on this cpu\n"); break; } + if (dabr.enabled) { + printf("Couldn't find free breakpoint register\n"); + break; + } mode = 7; cmd = inchar(); if (cmd == 'r') -- 2.26.2