Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1303058ybk; Thu, 14 May 2020 05:48:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7dj8hgOEZHWYxylGuAshXtiDEWS+rLxeh25c7HyUMpDzzL9nfPpddFpdNguHdb4q8+gSy X-Received: by 2002:a05:6402:1596:: with SMTP id c22mr4013115edv.100.1589460495756; Thu, 14 May 2020 05:48:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589460495; cv=none; d=google.com; s=arc-20160816; b=piPzhKImSlAxe53tBY6Xapaf/qvfBRdTnsiTs6Fmy9TowR1n5ChtilKPOe5+/rSSH7 ozDx2zY6iN3EioEEzIBxinWAIRO/dB3NtrfJpMjtOvppq+YBXcd+NRs7ha/z6whtVI4B secqB23bMfpQmvEJI4PRl1oPihWEB1Abey/oixVa0kN2FIkrksaQOqWCRSxIKNhEGs4H UyMoqMA7/MKj4Uz8CrCNlhBGDD0zwcw/M1DCupv2fVQnMHpfN7s844+ZH05veRZIT/PS RKMyaqD0CuCOaqhwqGmhRSW1fIdetGCCdYvgg5ef6B9xLlgOPZyCxQ7OTrvNdcQyjhOH u67w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=lguYI8+kEdyOali5FbQfIDU1A+SoZXisVW356lSyawE=; b=K3XXNdXL0HxLWpdzVA+deUVrnm8nC6mNoK/EQRRVgnmVHtODEeetd9bRnWqNXYrE2L y8sGz3YD8lPtjAc4ax9fWHfuM8POIJkw2jvUsSmbqKKIM4EK0e842e5T/965Wt1MXBrN HtbrTgQ8g34p9bTz2TGdrNPsJjH7QnEJxcOTioKf57J4LAghRPH6e7yRMGZKFvcx2ufj qzwFXGPgivKMUYVWbNOQvtx7dR8aZlDd2D3p75BXyb8fJZYgzsMZZv3oOQ1Aas/n439l gL8AOrY8IZPffpd86wORwWYlFBQKePviDS5BINnPAP/wG05+30rasx5xWDfIeuslR4k1 eH1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr18si2391798ejc.34.2020.05.14.05.47.52; Thu, 14 May 2020 05:48:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727835AbgENMnY (ORCPT + 99 others); Thu, 14 May 2020 08:43:24 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:59344 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726141AbgENMnA (ORCPT ); Thu, 14 May 2020 08:43:00 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 15A02E744D14484AA51E; Thu, 14 May 2020 20:42:58 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Thu, 14 May 2020 20:42:49 +0800 From: Huazhong Tan To: CC: , , , , , , Huazhong Tan Subject: [PATCH net-next 2/5] net: hns3: remove a duplicated printing in hclge_configure() Date: Thu, 14 May 2020 20:41:23 +0800 Message-ID: <1589460086-61130-3-git-send-email-tanhuazhong@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589460086-61130-1-git-send-email-tanhuazhong@huawei.com> References: <1589460086-61130-1-git-send-email-tanhuazhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since hclge_get_cfg() already has error print, so hclge_configure() should not print error when calling hclge_get_cfg() fail. Reported-by: Guangbin Huang Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index 1ff896a..b796d3f 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -1363,10 +1363,8 @@ static int hclge_configure(struct hclge_dev *hdev) int ret; ret = hclge_get_cfg(hdev, &cfg); - if (ret) { - dev_err(&hdev->pdev->dev, "get mac mode error %d.\n", ret); + if (ret) return ret; - } hdev->num_vmdq_vport = cfg.vmdq_vport_num; hdev->base_tqp_pid = 0; -- 2.7.4