Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: swCtBAYDjjCyyiUqg4mYkZSLQ0eObN975BJbFniIZu+olCbm32G7T6/8Q2eh04SdZ/klDr18cP
 UQqv3n+rPSpY1Its92krlFMTWOt8jgHsED/459C/lx7/B3+i6PpQ0R2V2f9U2OpeTVQIbxBmX2
 hifD8LMtyXKqP0QWcVT1lr0yyklabHo2D93jXkBJvkAUMoUKT8XUkxlnimdT2kW3MQNZpCowb8
 nZJZuTlI+6OP5fVmKICvya+4mo62kYB4TdnUgTDCHt2WKuc+DbKnD2aorLFhIoyLrVshyba5sv
 eWY=
IronPort-SDR: UQqrcpAkSslpR8S1FwmY3S9XoKwk9p/bamfgOsV3dOP5nfLLVeItZvQIXbu99uDVzyy5qGFeRn
 q/3UJoABjlwppkA7FGE6R35IKkv/Sf4sE=
IronPort-SDR: dOQ+2MaR1eefUwGBgVuaBVDuKbxo6IuUfevUdMIWNzRnJriKNVZWhzBAYBLQItiXfufb6QRhTF
 P+f96057z1OA==
WDCIronportException: Internal
Date:   Thu, 14 May 2020 14:34:26 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@wdc.com>
To:     Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
cc:     Bibo Mao <maobibo@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Paul Burton <paulburton@kernel.org>,
        Dmitry Korotin <dkorotin@wavecomp.com>,
        =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,
        Stafford Horne <shorne@gmail.com>,
        Steven Price <steven.price@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Mike Rapoport <rppt@linux.ibm.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] MIPS: update tlb even if pte entry has no change
In-Reply-To: <f165deac-1a71-dd88-dfe5-c1701f31567b@cogentembedded.com>
Message-ID: <alpine.LFD.2.21.2005141426160.6492@redsun52.ssa.fujisawa.hgst.com>
References: <1589422677-11455-1-git-send-email-maobibo@loongson.cn> <b46f4ac1-9738-6037-d60a-faebf2b4365c@cogentembedded.com> <f165deac-1a71-dd88-dfe5-c1701f31567b@cogentembedded.com>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 14 May 2020, Sergei Shtylyov wrote:

> >> If there are two threads reading the same memory and tlb miss happens,
> >> one thread fills pte entry, the other reads new pte value during page fault
> >> handling. PTE value may be updated before page faul, so the process need
> > 
> >     Fault.
> 
>     And "needs".
> 
> >> need update tlb still.
> 
>     Oh, and one "need" is enough. :-)

 Hmm, "the process need update" looks right to me (compare "the process 
need not update") as "need" is used as a modal verb in this sentence.  
Alternatively "the process needs to update" could be used (with "need" as 
a main verb, and "to" then).

 I'm not a native English speaker though, so I might be missing a usage 
subtlety here.

 NB I'd be in favour of capitalising "PTE" and "TLB" consistently 
throughout though as the norm is with acronyms.

  Maciej