Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1365066ybk; Thu, 14 May 2020 07:15:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxesgaZkcy7AVGuqdPCiU0KnjVSEru2WrbSbYXO6d9NphgwVFcbHGRY5hXLqlEnnz9CMQ1K X-Received: by 2002:aa7:c5cb:: with SMTP id h11mr2127407eds.136.1589465752468; Thu, 14 May 2020 07:15:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589465752; cv=none; d=google.com; s=arc-20160816; b=EV42NEpfjnSfTL2Oc5citcrmaPV4yUkIGtK4Cpw+IJNAVUVESxZqWZvXO2qUyoOH/v MEm3uaB4SpOHDkbbBnCNnZ2Lh3VsY/ItBBwkNJ3QzTCyYCfODAaRZWJGDNgt4aEWjqxw Qmq8cjTqSYc+aX1W+2q+XXaYszO36rdxD657w9bxQVojXtaYxAzw5zQVCW+BfsBti4FR 6lYX+uK8038ImGaVYvh5p7m26TLBdumdNJNYwTHBY1L5weS9m1rad70VzT3uXmWhjp91 ccoE6jYiSjKNgy47H84mQYFfjkAWL96Hcc/dDIW2fzcBdDvzCYk2IMDD8ag+mU01qvm0 808w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=wfWt8R4ZkyaOEVB7cAedAcUiRa6qs26ZXoTbOV1FxMg=; b=cFEzI5a7ajEiuMMuv1fmepHDgVm1B7XVtMJk08jMjLgNwCycOafG9iB9dZQSkIw2fO AP+avhKBhGyCX7O4VKxzkR0L47ELBWr95u02qx//BYfYhWXNh2hHu8qJcE/edkNeTpTX ihOIuAzgI0BTDNzEZV7UZZZYWMFB0UMD/O4g1XP8/xV7pRxOtDebc6dhOnVyoHW5bm9m NIrfDXoEIgvc5qoQmWB6sXkw5VZkOefn/JZrNrbzec8WqPSnG7TaC9wZCWI4zB1RzDUx mmDOwd+qCZwL/2NiGUQXDn7l9kxd5wTLH5pnb5WHlxlehuXKRTo2vf6+id7az2j8L4tD aZqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tn+uFlqx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me26si1988027ejb.309.2020.05.14.07.15.29; Thu, 14 May 2020 07:15:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tn+uFlqx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbgENOOH (ORCPT + 99 others); Thu, 14 May 2020 10:14:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:59110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgENOOH (ORCPT ); Thu, 14 May 2020 10:14:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6B8B20671; Thu, 14 May 2020 14:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589465646; bh=ptk6RhZzidMTuDqXDzMYBSDIiI5ksWNu/M5pgjk1MzE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tn+uFlqx6SmlGyrkqEGYMEcoGXw/yn2Xzp/ia/GSzW9s3pGovSxktqzLENFVZefwM KtcEBPP3ulIZ6epAymUsxyBlZjwlQI3h5NpmG/d/z5jQuBd2Ynnb8CsXWd4qi3Fbxu BMX8oo4h1hkvWP8+mHdVSrUOeX8/90mwrgk9BLS0= Date: Thu, 14 May 2020 16:14:03 +0200 From: Greg KH To: Jeffrey Hugo Cc: arnd@arndb.de, manivannan.sadhasivam@linaro.org, bjorn.andersson@linaro.org, wufan@codeaurora.org, pratanan@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 5/8] qaic: Implement data path Message-ID: <20200514141403.GB2643665@kroah.com> References: <1589465266-20056-1-git-send-email-jhugo@codeaurora.org> <1589465266-20056-6-git-send-email-jhugo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589465266-20056-6-git-send-email-jhugo@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 14, 2020 at 08:07:43AM -0600, Jeffrey Hugo wrote: > +struct qaic_execute { > + __u16 ver; /* struct version, must be 1 */ No need for structures to be versioned. If you change something, then add a new ioctl if you really needed it. thanks, greg k-h