Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [EXT] [PATCH 09/15] qed: use new module_firmware_crashed()
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <jeyu@kernel.org>, <akpm@linux-foundation.org>, <arnd@arndb.de>,
        <rostedt@goodmis.org>, <mingo@redhat.com>, <aquini@redhat.com>,
        <cai@lca.pw>, <dyoung@redhat.com>, <bhe@redhat.com>,
        <peterz@infradead.org>, <tglx@linutronix.de>,
        <gpiccoli@canonical.com>, <pmladek@suse.com>, <tiwai@suse.de>,
        <schlad@suse.de>, <andriy.shevchenko@linux.intel.com>,
        <keescook@chromium.org>, <daniel.vetter@ffwll.ch>,
        <will@kernel.org>, <mchehab+samsung@kernel.org>,
        <kvalo@codeaurora.org>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>
References: <20200509043552.8745-1-mcgrof@kernel.org>
 <20200509043552.8745-10-mcgrof@kernel.org>
 <2aaddb69-2292-ff3f-94c7-0ab9dbc8e53c@marvell.com>
 <20200509164229.GJ11244@42.do-not-panic.com>
 <e10b611e-f925-f12d-bcd2-ba60d86dd8d0@marvell.com>
 <20200512173431.GD11244@42.do-not-panic.com>
From:   Igor Russkikh <irusskikh@marvell.com>
Message-ID: <9badaaa7-ca79-9b6d-aa83-b1c28310ec4d@marvell.com>
Date:   Thu, 14 May 2020 17:53:41 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101
 Thunderbird/77.0
MIME-Version: 1.0
In-Reply-To: <20200512173431.GD11244@42.do-not-panic.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> 
> So do you mean like the changes below?
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> index f4eebaabb6d0..95cb7da2542e 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> @@ -7906,6 +7906,7 @@ int qed_dbg_all_data(struct qed_dev *cdev, void
> *buffer)
>  		rc = qed_dbg_grc(cdev, (u8 *)buffer + offset +
>  				 REGDUMP_HEADER_SIZE, &feature_size);
>  		if (!rc) {
> +			module_firmware_crashed();
>  			*(u32 *)((u8 *)buffer + offset) =
>  			    qed_calc_regdump_header(cdev, GRC_DUMP,
>  						    cur_engine,

Please remove this invocation. Its not a place where FW crash is happening.


>  		DP_NOTICE(p_hwfn,
>  			  "The MFW failed to respond to command 0x%08x
> [param 0x%08x].\n",
>  			  p_mb_params->cmd, p_mb_params->param);
> +		module_firmware_crashed();
>  		qed_mcp_print_cpu_info(p_hwfn, p_ptt);

This one is perfect, thanks!

Regards
  Igor