Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 May 2020 18:01:52 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Christian Herber <christian.herber@nxp.com>
Cc:     Oleksij Rempel <o.rempel@pengutronix.de>,
        Mark Rutland <mark.rutland@arm.com>,
        Marek Vasut <marex@denx.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        David Jander <david@protonic.nl>,
        "David S. Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [EXT] Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test
 support
Message-ID: <20200514160152.GU499265@lunn.ch>
References: <20200513123440.19580-1-o.rempel@pengutronix.de>
 <20200513133925.GD499265@lunn.ch>
 <20200513174011.kl6l767cimeo6dpy@pengutronix.de>
 <20200513180140.GK499265@lunn.ch>
 <20200514120959.b24cszsmkjvfzss6@pengutronix.de>
 <20200514133823.GO527401@lunn.ch>
 <AM0PR04MB704193C938ECC28DE9A1B28E86BC0@AM0PR04MB7041.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM0PR04MB704193C938ECC28DE9A1B28E86BC0@AM0PR04MB7041.eurprd04.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 14, 2020 at 03:47:16PM +0000, Christian Herber wrote:
> Hi Andrew,
> 
> > On Wed, May 13, 2020 at 03:39:00PM +0200, Andrew Lunn wrote:
> >> On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote:
> >>  ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER - the link partner is active.
> >>
> >>      The TJA1102 is able to detect it if partner link is master.
> >>
> > master is not a cable diagnostics issue. This is a configuration
> > issue.
> 

> Master is very relevant for cable diagnostics, as a cable
> measurement should not be done with an active link partner on the
> other end (i.e. a PHY in master mode trying to train the link).

> So if the measurement detects an active link partner disturbing the
> measurement, it is important to report this to the user.

So with 'normal' PHYs, we use autoneg to make the link go quiet. But
you don't have autoneg.

If there is no way to force the link quiet, then
ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER makes sense. But we need to
keep the meaning generic. I don't want it to mean a T1 PHY with an
active master peer. It should be usable for any reason the link cannot
be made to go quiet.

	Andrew