Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200513204111.1.I68404fc395a3dbc57c8a89ca02490013e8003a87@changeid>
 <20200514163048.GO4525@google.com>
In-Reply-To: <20200514163048.GO4525@google.com>
From:   Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Date:   Thu, 14 May 2020 10:44:59 -0700
Message-ID: <CANFp7mX0+fLgZgtVPin1B=AC-N4qSk6aPzsqcwYcazM_M1WLmw@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: hci_qca: Enable WBS support for wcn3991
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        bgodavar@codeaurora.org, Alain Michaud <alainm@chromium.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Thu, May 14, 2020 at 9:30 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Hi Abhishek,
>
> On Wed, May 13, 2020 at 08:41:25PM -0700, Abhishek Pandit-Subedi wrote:
> > WCN3991 supports transparent WBS (host encoded mSBC). Add a flag to the
> > device match data to show WBS is supported.
>
> In general this looks good to me, a few nits inside.
>
> > This requires the matching firmware for WCN3991 in linux-firmware:
> >         1a8b0dc00f77 (qca: Enable transparent WBS for WCN3991)
> >
> > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> > ---
> >
> >  drivers/bluetooth/hci_qca.c | 23 +++++++++++++++++------
> >  1 file changed, 17 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> > index b3fd07a6f8127..305976c4dcf42 100644
> > --- a/drivers/bluetooth/hci_qca.c
> > +++ b/drivers/bluetooth/hci_qca.c
> > @@ -75,6 +75,9 @@ enum qca_flags {
> >       QCA_HW_ERROR_EVENT
> >  };
> >
> > +enum qca_driver_flags {
> > +     QCA_DRV_WIDEBAND_SPEECH_SUPPORTED = 0x1,
>
> s/0x1/BIT(0)/

Will change in next version.

>
> > +};
>
> The 'driver'/'DRV' midfix is a bit misleading. WBS support is a device
> capability, it's not something the driver supports or doesn't. Maybe
> name it 'qca_capabilities' or similar.
>
> >  /* HCI_IBS transmit side sleep protocol states */
> >  enum tx_ibs_states {
> > @@ -187,10 +190,11 @@ struct qca_vreg {
> >       unsigned int load_uA;
> >  };
> >
> > -struct qca_vreg_data {
> > +struct qca_device_data {
> >       enum qca_btsoc_type soc_type;
> >       struct qca_vreg *vregs;
> >       size_t num_vregs;
> > +     uint32_t flags;
>
> capabilities?

Capabilities sounds good to me.

Thanks for the feedback.
Abhishek