Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1604487ybk;
        Thu, 14 May 2020 13:10:02 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzXCkg0v+ONnOKa6ZbnJx/6veUiH3BImdCJbto00aQxXE/o6GwUw6waGli0xwYGYPsZMf+b
X-Received: by 2002:a17:906:f112:: with SMTP id gv18mr5458697ejb.142.1589487001821;
        Thu, 14 May 2020 13:10:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1589487001; cv=none;
        d=google.com; s=arc-20160816;
        b=JSoHFtRt7El3WDSok34pKIPeWN0vFdLrnvqh2ZxvctVltsfTooQ0MnoCfJLuhVDH0U
         6ifINdCPZiKG9C+Oq6yOmt76h9++hORqHEGRmsmacYTQSrT7Vjd9rjazVH3xXX3Rx/AR
         kUAiyBxG2lDb4IzzkFG74+AmfKZOIiOJA4Tdkzpc21xUOz4uIDgpK6nRxci4IPRAfJ6U
         GtWzaq6yJP952L3PDnDfG0lajGYlL0rHXQbdVauzYsCfFsHtFmaI8Mj/ddC1fp0YUuw4
         dzuVONZytOl3HVr/pXcViXPayfel0gKgoJ72WQLWoJ8muPESSdVzigfiXDeHXxfX/z9Y
         uqaA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=RXq2bpCuJw/bMyvAYet54nYOIV2M83eP0JwQ0Y/7/Gc=;
        b=F8X12rVw6rzrjPB96FmmanowUp70Cfawz/YLBaznQSrCIiLikiBXvvgOlN6mBU3Fw5
         5biNSO5vGMx90Ebu3Daeb7QqYhwgAQXCqwrKnDqj1jB1wpzaHfS6/tvwem8QYSRXySK5
         V/MNt18nTuDSyhFI4qW2uB9V5Nu4tf9r6W1rWb7NreGy1Y+mB+VCgTpkJJzZlNc8c6CG
         +5I8E+E0XOUxrXwZOFshycpjkeYKUvvRxj14RATDF5xhqm1MVP6uZxK16s1XNv44FaSA
         l1KlplLuICKQYHB9wMdGRJWUWnKf4uGYyAvOPM1Zj3m4u4riUjSVSWjhYQIkTEJ5kQhQ
         hwHQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id c4si2267986ejm.465.2020.05.14.13.09.33;
        Thu, 14 May 2020 13:10:01 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728528AbgENTrG (ORCPT <rfc822;peterpeng024@gmail.com>
        + 99 others); Thu, 14 May 2020 15:47:06 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57012 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1728079AbgENTrG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 May 2020 15:47:06 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDC58C061A0C;
        Thu, 14 May 2020 12:47:05 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 3AF94128CF126;
        Thu, 14 May 2020 12:47:03 -0700 (PDT)
Date:   Thu, 14 May 2020 12:47:00 -0700 (PDT)
Message-Id: <20200514.124700.630104670938763588.davem@davemloft.net>
To:     kuba@kernel.org
Cc:     wenhu.wang@vivo.com, elder@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@vivo.com
Subject: Re: [PATCH] drivers: ipa: use devm_kzalloc for simplicity
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200514101516.0b2ccda2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20200514035520.2162-1-wenhu.wang@vivo.com>
        <20200514101516.0b2ccda2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 May 2020 12:47:03 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 14 May 2020 10:15:16 -0700

> On Wed, 13 May 2020 20:55:20 -0700 Wang Wenhu wrote:
>> Make a substitution of kzalloc with devm_kzalloc to simplify the
>> ipa_probe() process.
>> 
>> Signed-off-by: Wang Wenhu <wenhu.wang@vivo.com>
> 
> The code is perfectly fine as is. What problem are you trying to solve?

I agree, these kinds of transformations are kind of excessive.