Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1607727ybk; Thu, 14 May 2020 13:15:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuW+T0K5nlVa4Pj3OM3WDoHhwlH5k/jIkdF642pHG+IPw9D59mSK1Ieo+ZQs2NLcw/LI5s X-Received: by 2002:a17:906:7ac8:: with SMTP id k8mr5806140ejo.235.1589487306217; Thu, 14 May 2020 13:15:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589487306; cv=none; d=google.com; s=arc-20160816; b=lDEaD9HNAiYw5bz39lQsO37F2XqyYBCEhRBR+dizxP17Esw1kkpy7sCIOi3A7imMZb AlCD5w72UP5KtDAYUkjPCcBr8soRzbiPbdEk59nUdFZ9nC3pJBj6wAVya/jSpdyssKXC pBb5BB0asyxTk9Hwm2x9fXx/Z0bNQ1JPKlkgsHQWZ+JPWwjDSYwaPA2J9OqROVTTmMlK iKSJX5jzL/0qknU/b7vdc5DbOcy+aFcq5PtbdJC77o3xXoZmkhDb5UNzIXdTAl/fXMWI 2XN4fy0KQhBMYOtI0xPj5d7u7kmSetTWfm/9dU+rH6n72vz9+mdlF0Fbzvd56MBwvXR1 ftxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=3I8koedMnQ0/e6AfNz4/HCqK2DlY5Uwwdq+AOhHWu0M=; b=pZztuurxjQms1VFWzCVd+nVjLoMjr3xq+eIZfYoruCO7GqkOYDPaIT2wlrsrSvDfuZ /+EBaW4uqTko1tfmGGB4eyxmx9vd+zlZWuDaevRp9MRkr7swSevIzM/j/q7LW/WT8rV2 SRrLO+ODg3O8SXxOLfyOwmqixBa1U1lpfkut0AqWvBMwAVfzwC/cWc5DzRZGX1UrIwKu X+nXqmuvfFn6GDFtGTgyJzUlXaZQ9aaQtwC+wFwkg+om+VQc/jp1MNUhqX4WMjxmtvNj 2RzC1AwWknZf9lODLSiex2YCEx/4mIH41HFr/+zCfPJ6cD0n80PP+IKzAaVf+L/K6nLn wJ9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si2650305ejo.418.2020.05.14.13.14.43; Thu, 14 May 2020 13:15:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbgENUMD (ORCPT + 99 others); Thu, 14 May 2020 16:12:03 -0400 Received: from mga17.intel.com ([192.55.52.151]:50069 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726128AbgENUMD (ORCPT ); Thu, 14 May 2020 16:12:03 -0400 IronPort-SDR: f6VJMqpyNQnFXOYsA3gpv1ZVmEQWAD2TET9jw1am37ZfxrM/xDL9j/hXwm+a56MinDzRufPVtK z7uKZkWdUuLg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 13:12:02 -0700 IronPort-SDR: 3YwbjKvUIn8yjyXLkPLXwcFHK6Z3y60aShjP7PRQCK2VPMeH32Wif231YQZsmZiPc8e8+k1IzP uORq3w5aSpHA== X-IronPort-AV: E=Sophos;i="5.73,392,1583222400"; d="scan'208";a="280974194" Received: from rchatre-mobl.amr.corp.intel.com (HELO [10.254.66.120]) ([10.254.66.120]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 13:12:02 -0700 Subject: Re: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA To: Babu Moger , "tglx@linutronix.de" , "fenghua.yu@intel.com" , "bp@alien8.de" , "tony.luck@intel.com" Cc: "kuo-lang.tseng@intel.com" , "ravi.v.shankar@intel.com" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" References: <3a9c21e1b8108094d9132ca0c0271e8c7b93c847.1588808538.git.reinette.chatre@intel.com> From: Reinette Chatre Message-ID: Date: Thu, 14 May 2020 13:12:01 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Babu, On 5/14/2020 12:04 PM, Babu Moger wrote: > > >> -----Original Message----- >> From: Reinette Chatre >> Sent: Wednesday, May 6, 2020 6:50 PM >> To: tglx@linutronix.de; fenghua.yu@intel.com; bp@alien8.de; >> tony.luck@intel.com >> Cc: kuo-lang.tseng@intel.com; ravi.v.shankar@intel.com; mingo@redhat.com; >> Moger, Babu ; hpa@zytor.com; x86@kernel.org; >> linux-kernel@vger.kernel.org; Reinette Chatre >> Subject: [PATCH V3 2/4] x86/resctrl: Enumerate per-thread MBA >> >> From: Fenghua Yu >> ... >> diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c >> index 62b137c3c97a..bccfc9ff3cc1 100644 >> --- a/arch/x86/kernel/cpu/scattered.c >> +++ b/arch/x86/kernel/cpu/scattered.c >> @@ -35,6 +35,7 @@ static const struct cpuid_bit cpuid_bits[] = { >> { X86_FEATURE_CDP_L3, CPUID_ECX, 2, 0x00000010, 1 >> }, >> { X86_FEATURE_CDP_L2, CPUID_ECX, 2, 0x00000010, 2 >> }, >> { X86_FEATURE_MBA, CPUID_EBX, 3, 0x00000010, 0 }, >> + { X86_FEATURE_PER_THREAD_MBA, CPUID_ECX, 0, 0x00000010, 3 >> }, > > This is a CPUID feature. You can actually detect this feature without > checking vendor model in patch @1. This patch looks good to me. > This feature is different from the feature introduced in patch 1. Reinette