Date: Mon, 13 Mar 2006 16:14:35 -0800
From: Andrew Morton <akpm@osdl.org>
To: corbet@lwn.net (Jonathan Corbet)
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: radix tree safety
Message-Id: <20060313161435.30c2d865.akpm@osdl.org>
In-Reply-To: <20060314000114.24716.qmail@lwn.net>
References: <20060313155058.1389ee9a.akpm@osdl.org>
	<20060314000114.24716.qmail@lwn.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1107
Lines: 27

corbet@lwn.net (Jonathan Corbet) wrote:
>
> Andrew Morton <akpm@osdl.org> wrote:
> 
> > I don't really see the need - if someone goes and overindexes the data
> > structure's capacity then they have a bug and hopefully that'll turn up in
> > testing and will get fixed.
> > 
> > Or am I missing something obvious which makes radix-trees particularly
> > dangerous or subtle??
> 
> There's nothing in the interface documentation which says that a tag is
> an index to anything.  It's an integer value which can be attached to an
> item in a radix tree.  One has to look into the source to see the
> limitation built into it.  
> 
> If we don't want the tests, fine, but it might make sense to fix the
> interface documentation, at least, to note that "tag" is not an
> arbitrary integer value.
> 

Sure, we can live with the runtime cost of a documentation fix ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/