Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp143383ybk; Thu, 14 May 2020 19:02:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9kGezDk2BM3ZL6NchgGmYYvVnlBPumldB8DKud3kfQH/wVEKI9ZtUwX0vh8fT870i6y5L X-Received: by 2002:a17:906:70ca:: with SMTP id g10mr736806ejk.171.1589508170771; Thu, 14 May 2020 19:02:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589508170; cv=none; d=google.com; s=arc-20160816; b=t8jWMSYmcq7SFqaoeWNePpw8pmJ5Wt5QgARd2dfXvRD++Xx1kS5aBLDziFKqCvlMIl L2BwplOtcLyAdbIZoC+M1HpUnsCs1Uxpo2JpGrTp064nCEMX/4xzp3wqOl0Ob3/ryBb3 fbFzsF/zyA1ChSmRj3Fgyp5rroRf0VWOxO2ILjDRxo9isA494XGEAFUbtuI38l26YnmY sCRAMVs1+5o7+RtZ1gN6OrvaADFY/if7kSYsjzme2bzvMo/IeRRs17RDjUCFqDqx1hU4 fvz0rXzwE9llpgNlqYMpFVbAv57ZI8NiH4meJ7885OXLy1lHJ8fj1mj2bDM/gt2Qyp6M 9jOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=DlTd2+6X4/d43w2unGiHsVWVHUUZuqzUSUCN3TF06RI=; b=W+p9OGAs3UjxTNkLhVcgK6jH2XzBucnyZH8za6a9dLy2M67p0nTGQ3nsNzygxjFZbe n8tOlYvWb/gwcoQLxzRHoqwFWPOgt6IgHBNgVojlK8GL43PtWE3XOlEU856HPiJcCvIm BWUl4jKw4rz7Y28F/drtsRZmdhmfvBYVMEVsug3QQHiK883yIRZFgtnbvb4GXir+p4iv DKww0Uo7uZXwszrBh7oyeGUxVmO6f99+avEagzPX2j9YxlJ1ThVUy81O+UVavhcUYRdN wAQYSTJ0nEPWQHn58pXi39nVnB+YNfU2EfX7YUTgb2gNgT5ejbI7ZUrKZyYgPw5xOM0F f7Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l24si330515edr.396.2020.05.14.19.02.27; Thu, 14 May 2020 19:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728631AbgEOBB1 (ORCPT + 99 others); Thu, 14 May 2020 21:01:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726170AbgEOBB1 (ORCPT ); Thu, 14 May 2020 21:01:27 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15E6CC061A0C; Thu, 14 May 2020 18:01:27 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D33141288F375; Thu, 14 May 2020 18:01:25 -0700 (PDT) Date: Thu, 14 May 2020 18:01:25 -0700 (PDT) Message-Id: <20200514.180125.970958854699328151.davem@davemloft.net> To: frextrite@gmail.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org, kaber@trash.net, sfr@canb.auug.org.au, cai@lca.pw, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, joel@joelfernandes.org, madhuparnabhowmik10@gmail.com, paulmck@kernel.org Subject: Re: [PATCH net v2 1/2] ipmr: Fix RCU list debugging warning From: David Miller In-Reply-To: <20200514180102.26425-1-frextrite@gmail.com> References: <20200514180102.26425-1-frextrite@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 May 2020 18:01:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amol Grover Date: Thu, 14 May 2020 23:31:02 +0530 > ipmr_for_each_table() macro uses list_for_each_entry_rcu() > for traversing outside of an RCU read side critical section > but under the protection of rtnl_mutex. Hence, add the > corresponding lockdep expression to silence the following > false-positive warning at boot: > > [ 4.319347] ============================= > [ 4.319349] WARNING: suspicious RCU usage > [ 4.319351] 5.5.4-stable #17 Tainted: G E > [ 4.319352] ----------------------------- > [ 4.319354] net/ipv4/ipmr.c:1757 RCU-list traversed in non-reader section!! > > Fixes: f0ad0860d01e ("ipv4: ipmr: support multiple tables") > Signed-off-by: Amol Grover Applied.