Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 1/3] cpufreq: fix the return value in
 'cpufreq_boost_set_sw()'
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
CC:     <viresh.kumar@linaro.org>, <Souvik.Chakravarty@arm.com>,
        <Thanu.Rangarajan@arm.com>, <Sudeep.Holla@arm.com>,
        <guohanjun@huawei.com>, <john.garry@huawei.com>,
        <jonathan.cameron@huawei.com>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1588929064-30270-1-git-send-email-wangxiongfeng2@huawei.com>
 <1588929064-30270-2-git-send-email-wangxiongfeng2@huawei.com>
 <28914151.3vfbF0e6KZ@kreacher>
From:   Xiongfeng Wang <wangxiongfeng2@huawei.com>
Message-ID: <881629ba-17fb-114c-858f-43b62e32b421@huawei.com>
Date:   Fri, 15 May 2020 09:28:22 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <28914151.3vfbF0e6KZ@kreacher>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rafael,

Thanks for your reply !

On 2020/5/14 21:54, Rafael J. Wysocki wrote:
> On Friday, May 8, 2020 11:11:02 AM CEST Xiongfeng Wang wrote:
>> When I try to add SW BOOST support for CPPC, I got the following error:
>> cpufreq: cpufreq_boost_trigger_state: Cannot enable BOOST
>> cpufreq: store_boost: Cannot enable BOOST!
>>
>> It is because return value 1 of 'freq_qos_update_request()' means the
>> effective constraint value has changed, not a error code on failures.
>> But for 'cpufreq_driver.set_boost()', a nonzero return value means
>> failure. So change 'ret' to zero when 'freq_qos_update_request()'
>> returns a positive value.
>>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
>> ---
>>  drivers/cpufreq/cpufreq.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>> index 4adac3a..475fb1b 100644
>> --- a/drivers/cpufreq/cpufreq.c
>> +++ b/drivers/cpufreq/cpufreq.c
>> @@ -2522,6 +2522,8 @@ static int cpufreq_boost_set_sw(int state)
>>  		ret = freq_qos_update_request(policy->max_freq_req, policy->max);
>>  		if (ret < 0)
>>  			break;
>> +		else
>> +			ret = 0;
>>  	}
>>  
>>  	return ret;
>>
> 
> I would change cpufreq_boost_trigger_state() to take the 1 into account properly
> instead.

Thanks for your suggestion. I will change it in the next version.

Thanks,
Xiongfeng

> 
> Thanks!
> 
> 
> 
> 
> .
>