Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 May 2020 10:45:52 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Rob Herring <robh@kernel.org>
Cc:     devel@driverdev.osuosl.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        Pi-Hsun Shih <pihsun@chromium.org>,
        Sheng Pan <span@analogixsemi.com>
Subject: Re: [PATCH v10 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP
 transmitter binding
Message-ID: <20200515024552.GA11753@xin-VirtualBox>
References: <cover.1588747998.git.xji@analogixsemi.com>
 <b720f7d2c5338813d31b7f715f59ca68c367d5a8.1588747998.git.xji@analogixsemi.com>
 <20200514145432.GA6091@bogus>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200514145432.GA6091@bogus>
User-Agent: Mutt/1.5.24 (2015-08-30)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from xin-VirtualBox (114.247.245.254) by HK2PR06CA0016.apcprd06.prod.outlook.com (2603:1096:202:2e::28) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.3000.25 via Frontend Transport; Fri, 15 May 2020 02:45:58 +0000
X-Originating-IP: [114.247.245.254]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9ccce5ed-8c26-4624-543e-08d7f87a18f0
X-MS-TrafficTypeDiagnostic: BY5PR04MB6583:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR04MB65837A370268722E5C0FC8A7C7BD0@BY5PR04MB6583.namprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-Forefront-PRVS: 04041A2886
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UqEWEg/X8iIa+znI8yLYOZX0/TAl9tbeVRAaOhyvknmkKVsG3gyzWZqBxIXJNml2enKYlBgTvdAvR0h2JZWh1Ex5rbBuNpBxXZ/ruYJr5g0aKhIfkWRlgRZ93F8KEb1NSqhOhaC8oTFbXOn95FpOKrW1qA2ImvWmb2uA/Vff75vApYKkXiv787wNoNYiRvTw4NoY3vcUW1H50+WobQZkP8Yi10kv2jJhQ1uimWPhhv+Q+fhycTNxI3N50PzHaa5UrCf7MpAHkePHoHMbeY2ac0rIgtzggKr7Jw03nNTLo7oHKF0o94nz+YHdTgmqPStqezGLElzQURAb5YCq1M2rs/2o5j6PBPCSQjJRfQjG+wFMYyZ829xgbHa0DIyTgo7Kj0uHq/GdCbpDH8fIDjnRf+01Nm3jjYba5UcHYXc/L/z0Zvlc5kRZNFXtqNcteAbLh0aXt0z6I+OV9VpuhSSCI7a+762lfDW0Gzj8m+qNe9kgIa41k/ejJieZXK0wdNwbNAT3AeyNQly0KuyMLxk3QA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR04MB6739.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(376002)(366004)(396003)(39840400004)(8936002)(2906002)(6496006)(52116002)(8676002)(316002)(6916009)(86362001)(54906003)(16526019)(7416002)(26005)(186003)(956004)(55016002)(4326008)(66946007)(1076003)(33716001)(5660300002)(9686003)(66556008)(478600001)(107886003)(33656002)(66476007)(6666004);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: y976YP3kawGNAFPOYmD+WLiJCIsmiMQqB7LOsHSvp6wFlEdsrgu2yvkXdqLbbUaPCYqKSQX8B8l4hd2QmS7FtQ5RDy5AEFXrS7mv+klnpYfdu2cAVI7XHETV6V7Zadaxhiib07mEHDrdhPXxNM3jFdt/vfl20DQLhNofnEjZyXuL9xOozrvqu/mo/TqjENIvlJvQXN3ZvNYe5Us7U+jGqTf8QefMOZybBS7MJVn/NaLsyR0VcAWNZ7U7w2pxu6FiUjjW2HxXtypUfmpt9HdK0Pn/pQO1Qx9tKQXxdBJJnzN4gNNF/oCeIdMOf46P2V6wrsYEy4jAUJLPr/faTBZidoRUuIChxESq6pU5NzHRDGcLqSfMf+ZFjc2JffC1ELyPpGB8akPQ7ELrT3l8HE9ECJh4bQKqZm4BGlYelAUKLT4Adk3eBK7FAtKZAJBXqe3c5RWIceCghodoaGuolH8rlwo4tu9+GwyhunMKiri/n/ZT4rgRbdSxyPj4rBHyIoCg
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ccce5ed-8c26-4624-543e-08d7f87a18f0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 02:45:58.7233
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pqz+qU3xje6GJ9oXnD5pPlqfdh+FloccM0M4DdPzd0TsHNyust/7ilgxysseOqNncuS8zRd0UtuWleUpb1DRIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6583
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob Herring,

Thanks for your comments.

On Thu, May 14, 2020 at 09:54:32AM -0500, Rob Herring wrote:
> On Wed, May 06, 2020 at 03:04:20PM +0800, Xin Ji wrote:
> > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> > for portable device. It converts MIPI to DisplayPort 1.3 4K.
> > 
> > You can add support to your board with binding.
> 
> We have an example in the binding, no reason to also put in the commit 
> msg.
OK
> 
> > 
> > Example:
> > 	anx7625_bridge: encoder@58 {
> > 		compatible = "analogix,anx7625";
> > 		reg = <0x58>;
> > 		status = "okay";
> > 		enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > 		reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> > 
> > 		ports {
> > 			#address-cells = <1>;
> > 			#size-cells = <0>;
> > 
> > 			mipi2dp_bridge_in: port@0 {
> > 				reg = <0>;
> > 				anx7625_in: endpoint {
> > 					remote-endpoint = <&mipi_dsi>;
> > 				};
> > 			};
> > 
> > 			mipi2dp_bridge_out: port@1 {
> > 				reg = <1>;
> > 				anx7625_out: endpoint {
> > 					remote-endpoint = <&panel_in>;
> > 				};
> > 			};
> > 		};
> > 	};
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  .../bindings/display/bridge/analogix,anx7625.yaml  | 98 ++++++++++++++++++++++
> >  1 file changed, 98 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > new file mode 100644
> > index 0000000..6e54176
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -0,0 +1,98 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2019 Analogix Semiconductor, Inc.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
> > +
> > +maintainers:
> > +  - Xin Ji <xji@analogixsemi.com>
> > +
> > +description: |
> > +  The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> > +  designed for portable devices.
> > +
> > +properties:
> > +  "#address-cells": true
> > +  "#size-cells": true
> 
> These don't belong here.
OK
> 
> > +
> > +  compatible:
> > +    items:
> > +      - const: analogix,anx7625
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    description: used for interrupt pin B8.
> > +    maxItems: 1
> > +
> > +  enable-gpios:
> > +    description: used for power on chip control, POWER_EN pin D2.
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    description: used for reset chip control, RESET_N pin B7.
> > +    maxItems: 1
> > +
> > +  ports:
> > +    type: object
> > +
> > +    properties:
> > +      port@0:
> > +        type: object
> > +        description:
> > +          Video port for MIPI DSI input.
> > +
> > +      port@1:
> > +        type: object
> > +        description:
> > +          Video port for panel or connector.
> > +
> > +    required:
> > +        - port@0
> > +        - port@1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    i2c0 {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        anx7625_bridge: encoder@58 {
> 
> Drop any unused labels.
OK
> 
> > +            compatible = "analogix,anx7625";
> > +            reg = <0x58>;
> > +            enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
> > +            reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
> > +
> > +            ports {
> > +                #address-cells = <1>;
> > +                #size-cells = <0>;
> > +
> > +                mipi2dp_bridge_in: port@0 {
> > +                    reg = <0>;
> > +                    anx7625_in: endpoint {
> > +                        remote-endpoint = <&mipi_dsi>;
> > +                    };
> > +                };
> > +
> > +                mipi2dp_bridge_out: port@1 {
> > +                    reg = <1>;
> > +                    anx7625_out: endpoint {
> > +                        remote-endpoint = <&panel_in>;
> > +                    };
> > +                };
> > +            };
> > +        };
> > +    };
> > -- 
> > 2.7.4
> >