Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init
To:     jiaxun.yang@flygoat.com,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>
References: <1589508901-18077-1-git-send-email-yangtiezhu@loongson.cn>
 <ECE71DFC-57D3-4132-BB85-609448B29238@flygoat.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <636ba812-3849-2667-d625-ab7e35d5ac36@loongson.cn>
Date:   Fri, 15 May 2020 11:09:56 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <ECE71DFC-57D3-4132-BB85-609448B29238@flygoat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05/15/2020 10:33 AM, Jiaxun Yang wrote:
>
> 于 2020年5月15日 GMT+08:00 上午10:15:00, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>> When ATI Radeon graphics card has been compiled directly into the kernel
>> instead of as a module, we should make sure the firmware for the model
>> (check available ones in /lib/firmware/radeon) is built-in to the kernel
>> as well, otherwise there exists the following fatal error during GPU init,
>> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
>>
> The commit message looks shocking.
>
> You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module in Kconfig"

OK, I will modify the patch subject and send v2.

>
> Thanks.