Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp239752ybk; Thu, 14 May 2020 22:39:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHH1RmaOzzoVLRaXWza1UwGXMolQzq1y1dhzvT+kQKvNx5PDwQZ/0C7zvKYAIR++qMWrOX X-Received: by 2002:a17:906:7204:: with SMTP id m4mr1308642ejk.48.1589521194354; Thu, 14 May 2020 22:39:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589521194; cv=none; d=google.com; s=arc-20160816; b=xe6zWMJOiITX9R6Bz8fhwAj0vVOyH3HfpIj+4jq+YTt5dpCU6J4qQUP6nmv/gTPgyR 1SA/1aeSvFfRRl5ice6jkuEZjqK2s6TAtewlYzRV8//Lo7uYIERlG5/Y7ywiOz/QaG4J LYlPf2lt4bfbb87Pr1dvokBz8hl/NqQyWd6DvrBO/ajtzKXMjk4WRNHQnRSgKV1ULH86 Nvyxq1ha6rX4E8fb7NWLoOGnCl1tfKvNDKvjAU4a4BDNcJEOScUzKTpviXe+HYu19F0L Wh+uAks1Mwb9AxyG4LmIwDYTqMjSzOHxSBSK5oXeairO3KiKgeGbNjHogF9BL6GsGoTq tLpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KOggRpNEgKFylyexw+1c1f6l93lw4QNc2eenWWVkve8=; b=VNB2fRpznjiJEUfoAWM42JLPUiMb70Jk/4HMoq4OXRhSzCYRvBLkQfJoT2H4Ngc9HQ QQwtxtYKR78YtRUSP6/TLJPKVwJYRMYTQ5qiyASUTwlVupeMATF/XnWT4GyLdMNEs9bt eOmdiSyV3xPnDFGg69Z62gABcyz8jGOk8CQHk4IY4GZG1X4NyQGSutEZuo5ZloAx9ibu EaH8K7/uFeN+3HFif/ACAjSihojUd+NmfFdl7tiSy8m7G/myICFH/E4pB9M686o8AUu8 yTH5b0EOvBslyTZDc+tZxByPwb7ONsFkmU01u0FvcldK8cbeSaOWDUB1ku0U+HSmlIs4 QC2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OlniUzH1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m14si668048ejb.514.2020.05.14.22.39.30; Thu, 14 May 2020 22:39:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OlniUzH1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726288AbgEOFhn (ORCPT + 99 others); Fri, 15 May 2020 01:37:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:45210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbgEOFhn (ORCPT ); Fri, 15 May 2020 01:37:43 -0400 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64DA720671 for ; Fri, 15 May 2020 05:37:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589521062; bh=SuVHOy8cA7zaee1Wtzeq5edqdj/GnFqaX2yUkDrhAUs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OlniUzH1ZnVwPBp/5Z3f/4e+e1z2AkmWp7CXReQ5bC4a/J0AcN6uLOZk2uKHdE2nD DvEWLiFw3/FlM8E1wusUmg+kF4LYFPWPoG0k1a5LW7XTQEI6Ad/qp7ehTLau947an4 lzsW9eFBgsqGQl3YpzCzNSzjtSVWLK/39HRTgqcw= Received: by mail-wm1-f50.google.com with SMTP id n5so1167386wmd.0 for ; Thu, 14 May 2020 22:37:42 -0700 (PDT) X-Gm-Message-State: AOAM532Tul6V+ttQWfvlMDDaGgbZ/ssWJrMIkkUYKjzrcaG4n3RZKL09 4mF6dY3AAbJGilz1y5f3MjBAMdbQnzKIGzjHP5kTxw== X-Received: by 2002:a1c:8141:: with SMTP id c62mr1071698wmd.21.1589521060978; Thu, 14 May 2020 22:37:40 -0700 (PDT) MIME-Version: 1.0 References: <20200505134926.578885807@linutronix.de> <20200505135314.808628211@linutronix.de> In-Reply-To: <20200505135314.808628211@linutronix.de> From: Andy Lutomirski Date: Thu, 14 May 2020 22:37:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch V4 part 4 15/24] x86/db: Split out dr6/7 handling To: Thomas Gleixner Cc: LKML , X86 ML , "Paul E. McKenney" , Andy Lutomirski , Alexandre Chartre , Frederic Weisbecker , Paolo Bonzini , Sean Christopherson , Masami Hiramatsu , Petr Mladek , Steven Rostedt , Joel Fernandes , Boris Ostrovsky , Juergen Gross , Brian Gerst , Mathieu Desnoyers , Josh Poimboeuf , Will Deacon , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 5, 2020 at 7:16 AM Thomas Gleixner wrote: > > From: Peter Zijlstra > > DR6/7 should be handled before nmi_enter() is invoked and restore after > nmi_exit() to minimize the exposure. > > Split it out into helper inlines and bring it into the correct order. > + * > + * Entry text is excluded for HW_BP_X and cpu_entry_area, which > + * includes the entry stack is excluded for everything. > + */ > + get_debugreg(*dr7, 6); > + set_debugreg(0, 7); Fortunately, PeterZ is hiding in a brown paper bag, so I don't have to comment :) Other than that: Acked-by: Andy Lutomirski