Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Georgi Djakov <georgi.djakov@linaro.org>,
        Matthias Kaehlcke <mka@chromium.org>
Cc:     Sandeep Maheswaram <sanm@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Doug Anderson <dianders@chromium.org>,
        linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Manu Gautam <mgautam@codeaurora.org>,
        Chandana Kishori Chiluveru <cchiluve@codeaurora.org>,
        Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver
In-Reply-To: <abbc3f8c-c8c9-c189-735e-f8058dab3e40@linaro.org>
References: <1585718145-29537-1-git-send-email-sanm@codeaurora.org> <1585718145-29537-3-git-send-email-sanm@codeaurora.org> <878shu4uwk.fsf@kernel.org> <875zcy4uuj.fsf@kernel.org> <20200514171352.GP4525@google.com> <abbc3f8c-c8c9-c189-735e-f8058dab3e40@linaro.org>
Date:   Fri, 15 May 2020 08:54:52 +0300
Message-ID: <87tv0h3fpv.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Georgi Djakov <georgi.djakov@linaro.org> writes:
> On 5/14/20 20:13, Matthias Kaehlcke wrote:
>> On Thu, May 14, 2020 at 02:30:28PM +0300, Felipe Balbi wrote:
>>> Felipe Balbi <balbi@kernel.org> writes:
>>>
>>>> Hi,
>>>>
>>>> Sandeep Maheswaram <sanm@codeaurora.org> writes:
>>>>> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
>>>>> +{
>>>>> +	struct device *dev =3D qcom->dev;
>>>>> +	int ret;
>>>>> +
>>>>> +	if (!device_is_bound(&qcom->dwc3->dev))
>>>>> +		return -EPROBE_DEFER;
>>>>
>>>> this breaks allmodconfig. I'm dropping this series from my queue for
>>>> this merge window.
>>>
>>> Sorry, I meant this patch ;-)
>>=20
>> I guess that's due to INTERCONNECT being a module. There is currently a
>
> I believe it's because of this:
> ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undefin=
ed!
>
>> discussion about this  with Viresh and Georgi in response to another
>> automated build failure. Viresh suggests changing CONFIG_INTERCONNECT
>> from tristate to bool, which seems sensible to me given that interconnect
>> is a core subsystem.
>
> The problem you are talking about would arise when INTERCONNECT=3Dm and
> USB_DWC3_QCOM=3Dy and it definitely exists here and could be triggered wi=
th
> randconfig build. So i suggest to squash also the diff below.
>
> Thanks,
> Georgi
>
> ---8<---
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 206caa0ea1c6..6661788b1a76 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -129,6 +129,7 @@ config USB_DWC3_QCOM
>  	tristate "Qualcomm Platform"
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on EXTCON || !EXTCON
> +	depends on INTERCONNECT || !INTERCONNECT

I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bound=
()

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl6+LqwACgkQzL64meEa
mQZBeg//fCQv3kTlgIEG58i2znWQ4FsluvuUsxpT6c2Pvumr98MxZU6KQYo+914F
8anWhvq67+Nn52KaibXXnbff7jcc1wY6o/soN8EKEhVtGLJZ2K5o0YJJsj71gvf6
Ktphgmj6UDlkYa+dJdITSSKIxAFqPfwVBiC59RqA1TCKqZsVMiEfPXgmxVyxzML0
aNIcN8BEB994PM0N0nNfDCw01auhVyzkffeEywCrSRbQ/AigPGxr8KaN0hg1suLJ
1XQ6X+texaRV1Z/Mu5ivIQs76oumM15LHCHOCP3+bNH7ShQdCXoDcAJYR3IYcDQX
gSZjGAevnOEaNo9wAS2MgmZ32DnoWadekMxBICmORFlcdDjWspdqCQylUqvsyjX8
dNZcqqv5vFCVJX2vJ5wfeH16PemC+ex0GW6zI6Q1DzsjOIipJg6RsGLyVzT6JPbU
F2r+EAqCSGute04Ne2lYiCwTvdIKNj+Xudm2YxDKGeSMlj+jYboGmJMuk83Ebogf
B7MaoCWhXOlcfBrUL+9qdp9N5hBU26kGwmuoNXahnpxgKZGQUGZUmC4c6ko7YksJ
of+dSkLvbvyP71CrJAgiKyr8pBQbPgim/wxIBDxtQDZKQ9pwUx86Y/cWJT6lPSvZ
NkiXDlO/gQoq2jnPSstmuQUa8gnoCdylvsrreuAaAY/UuXimiP4=
=oYkY
-----END PGP SIGNATURE-----
--=-=-=--