Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp254534ybk; Thu, 14 May 2020 23:11:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwa88VTvm9EUvbEiOdbs6RvTp/jJrJoz+Sqc56QPR2A2Yl4wWiX4dII22IX+rhtMY5ldYot X-Received: by 2002:a17:906:a415:: with SMTP id l21mr1409715ejz.100.1589523071364; Thu, 14 May 2020 23:11:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589523071; cv=none; d=google.com; s=arc-20160816; b=iCSVzoYWubVcTkjOeb/EJI8gqhPYljy5vSs8u4ZRe21lzQKBM53b2/SIUCYwFYlwdG WlZFNYZO4Qpc8/2MU70Wog8hGfcOrz8IoWS15bEEgGpplozj0ao7qkYQFG4zo83Xuu5+ 8zFr/6fbYTnsctuNzn/i86WOxYwqUaiNRMSaqIbWW96BxchgfniZ5N6dMdHEfNrMQ6OS 8Ts7UHgConOCJZtZNYDAIAxex2mcyba+Kmcg7rzNjmYnnIcd+mUCDAT9klgHjXYoosXY NVvZPyeFA76GMk+JCOCHnpRTpwVEmW1TYIC2Z5XcHcmMLK6mBg+R62KDy3oMYvDcfggT eZ8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OWRfhQAZ9rQZSqHkKqANsC+0jlszt/GjlJsS09xcESc=; b=oQ626EfurcQGGCJ4NKjP2EXuOUPkvwAC2UHeBrPMwYC5bD6+Npqxa/ftbomVaFpQbB FI3TBWbZeQPMp+eU661jo6iTuKUjq3d1ego347PSlACtQr7eGtS00bRUcBYNU2Oj8Z+O PKdU+Gv1ybwit6ie/b2ljgk6PIn/g9TgZIyLVlox8wJHzla58WvRAjzeNcXNbGS9klFA 371LptfhuqM5IillkJhqpzgiuhxEB0XPjpNQVOsv1DALuYtJgoD0kGq398lH7ZHa8jEt S2NHWBBkdqm+T2U3UncmvOn1TickOwRhgr6UEDL5bwzlkIj+0MFHZk1OHWdu+frbg9A5 x4Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HpXT4he0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s25si636292ejz.262.2020.05.14.23.10.47; Thu, 14 May 2020 23:11:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HpXT4he0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726607AbgEOGJT (ORCPT + 99 others); Fri, 15 May 2020 02:09:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:34670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbgEOGJS (ORCPT ); Fri, 15 May 2020 02:09:18 -0400 Received: from localhost (unknown [122.178.196.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62AAE2065F; Fri, 15 May 2020 06:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589522958; bh=kgLtAKAfE9tPkcpQWYFZxlQ+PomFFTOqOI8Aot+uWlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HpXT4he0xdWcmrcjS/VNjmglDEDWEmj7Vq5dRgrt8nABPbVNpJdj7fQGxuf5pbFTW sX6vt6Rt6SyZc0kmQsycfvi27XzW5xB1arzxtopdHNvrEf5B9Wf36v7BA7aq9ErklA M3tNNI2EvAsesfJnoomkv6nPDwSLn/APVqdO7Cgo= Date: Fri, 15 May 2020 11:39:11 +0530 From: Vinod Koul To: Andy Shevchenko Cc: Serge Semin , Serge Semin , Viresh Kumar , Rob Herring , Alexey Malahov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Dan Williams , linux-mips@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/6] dt-bindings: dma: dw: Add max burst transaction length property Message-ID: <20200515060911.GF333670@vkoul-mobl> References: <20200306131048.ADBE18030797@mail.baikalelectronics.ru> <20200508105304.14065-1-Sergey.Semin@baikalelectronics.ru> <20200508105304.14065-3-Sergey.Semin@baikalelectronics.ru> <20200508111242.GH185537@smile.fi.intel.com> <20200511200528.nfkc2zkh3bvupn7l@mobilestation> <20200511210138.GN185537@smile.fi.intel.com> <20200511213531.wnywlljiulvndx6s@mobilestation> <20200512090804.GR185537@smile.fi.intel.com> <20200512114946.x777yb6bhe22ccn5@mobilestation> <20200512123840.GY185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200512123840.GY185537@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-05-20, 15:38, Andy Shevchenko wrote: > On Tue, May 12, 2020 at 02:49:46PM +0300, Serge Semin wrote: > > On Tue, May 12, 2020 at 12:08:04PM +0300, Andy Shevchenko wrote: > > > On Tue, May 12, 2020 at 12:35:31AM +0300, Serge Semin wrote: > > > > On Tue, May 12, 2020 at 12:01:38AM +0300, Andy Shevchenko wrote: > > > > > On Mon, May 11, 2020 at 11:05:28PM +0300, Serge Semin wrote: > > > > > > On Fri, May 08, 2020 at 02:12:42PM +0300, Andy Shevchenko wrote: > > > > > > > On Fri, May 08, 2020 at 01:53:00PM +0300, Serge Semin wrote: > > ... > > I leave it to Rob and Vinod. > It won't break our case, so, feel free with your approach. I agree the DT is about describing the hardware and looks like value of 1 is not allowed. If allowed it should be added.. > P.S. Perhaps at some point we need to > 1) convert properties to be u32 (it will simplify things); > 2) convert legacy ones to proper format ('-' instead of '_', vendor prefix added); > 3) parse them in core with device property API. These suggestions are good and should be done. -- ~Vinod