Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Georgi Djakov <georgi.djakov@linaro.org>,
        Matthias Kaehlcke <mka@chromium.org>
Cc:     Sandeep Maheswaram <sanm@codeaurora.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Stephen Boyd <swboyd@chromium.org>,
        Doug Anderson <dianders@chromium.org>,
        linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Manu Gautam <mgautam@codeaurora.org>,
        Chandana Kishori Chiluveru <cchiluve@codeaurora.org>,
        Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver
In-Reply-To: <090e48d7-7988-eea1-bf39-f6820578d354@linaro.org>
References: <1585718145-29537-1-git-send-email-sanm@codeaurora.org> <1585718145-29537-3-git-send-email-sanm@codeaurora.org> <878shu4uwk.fsf@kernel.org> <875zcy4uuj.fsf@kernel.org> <20200514171352.GP4525@google.com> <abbc3f8c-c8c9-c189-735e-f8058dab3e40@linaro.org> <87tv0h3fpv.fsf@kernel.org> <090e48d7-7988-eea1-bf39-f6820578d354@linaro.org>
Date:   Fri, 15 May 2020 09:29:33 +0300
Message-ID: <87r1vl3e42.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Georgi Djakov <georgi.djakov@linaro.org> writes:
>>>>>> Sandeep Maheswaram <sanm@codeaurora.org> writes:
>>>>>>> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
>>>>>>> +{
>>>>>>> +	struct device *dev =3D qcom->dev;
>>>>>>> +	int ret;
>>>>>>> +
>>>>>>> +	if (!device_is_bound(&qcom->dwc3->dev))
>>>>>>> +		return -EPROBE_DEFER;
>>>>>>
>>>>>> this breaks allmodconfig. I'm dropping this series from my queue for
>>>>>> this merge window.
>>>>>
>>>>> Sorry, I meant this patch ;-)
>>>>
>>>> I guess that's due to INTERCONNECT being a module. There is currently a
>>>
>>> I believe it's because of this:
>>> ERROR: modpost: "device_is_bound" [drivers/usb/dwc3/dwc3-qcom.ko] undef=
ined!
>>>
>>>> discussion about this  with Viresh and Georgi in response to another
>>>> automated build failure. Viresh suggests changing CONFIG_INTERCONNECT
>>>> from tristate to bool, which seems sensible to me given that interconn=
ect
>>>> is a core subsystem.
>>>
>>> The problem you are talking about would arise when INTERCONNECT=3Dm and
>>> USB_DWC3_QCOM=3Dy and it definitely exists here and could be triggered =
with
>>> randconfig build. So i suggest to squash also the diff below.
>>>
>>> Thanks,
>>> Georgi
>>>
>>> ---8<---
>>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>>> index 206caa0ea1c6..6661788b1a76 100644
>>> --- a/drivers/usb/dwc3/Kconfig
>>> +++ b/drivers/usb/dwc3/Kconfig
>>> @@ -129,6 +129,7 @@ config USB_DWC3_QCOM
>>>  	tristate "Qualcomm Platform"
>>>  	depends on ARCH_QCOM || COMPILE_TEST
>>>  	depends on EXTCON || !EXTCON
>>> +	depends on INTERCONNECT || !INTERCONNECT
>>=20
>> I would prefer to see a patch adding EXPORT_SYMBOL_GPL() to device_is_bo=
und()
>
> Agree, but just to clarify, that these are two separate issues that need =
to
> be fixed. The device_is_bound() is the first one and USB_DWC3_QCOM=3Dy co=
mbined
> with INTERCONNECT=3Dm is the second one.

If INTERCONNECT=3Dm, QCOM3 shouldn't be y. I think the following is
enough:

	depends on INTERCONNECT=3Dy || INTERCONNECT=3DUSB_DWC3_QCOM

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl6+Ns0ACgkQzL64meEa
mQbAXRAAx1nSiv+90Ab9qTZwL9hwRv7Z81MYwG4smKR+OwjyzOR7s9P7KX7OiRvx
nnoleEKaK596cmTgrFxejEKrs5ASfMh8d8r9nZyv+PALk+uIf5t/IdQ+GrzC9Odg
TaFHL1FsV63YsCL94rkhYNDlFZr9HcF0FslmbW8Edk5BrdMn7CJiihpGEj2woowc
o4R4iWfletBlWIDffYq/KnHZbNfai1NOPlS1Tqu+qLtH50UMUGYD42OehueZK8id
J9+BGUBJVx4fCHAN5KyWuOm0BKzd4c9uQJRP7Yr6jlK5Q3fG7xqlyvXC0a38eHhm
VuMCR2WATX2EhMD6zR+O+d7+od0pyaM+6pzLzVsJrj5v/235Ncwt3t8PUAESoNI/
6jvQ3TqVRfArjUU9lWIoez3t82CHbLpNW7XNgCo7aXE0YWqudek0HX1jShT86Oyg
tcdYc3EfBXQyRm893r7zD055MT75xwhfE7I+snc16b1xdPHIDvFZJo9/5Q6BmJq+
FSIBHqKOLP+s4lqAVKdmdxki1OKc8wY1K3LB8mT5ksAkaPmhqCBPJ8k8tf9ldxNC
eL+7W7Ja/cXZ5Uu/Gvv7wxP83sER6jXuGbbtxHU9GUAfVWN/0oHFa2OsXo9pxCPY
6fFr6/b0nBD+SWgIFt2ZaFgBisebVRrAVdck8I0mqcyJwbF2yMo=
=2Mnr
-----END PGP SIGNATURE-----
--=-=-=--