Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp267986ybk; Thu, 14 May 2020 23:39:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFt+Zjx8j59OO1aTUfn0AIZazZdmYW+IpPrLi9tNxpziAi5nSEhO7cPmJYqADFKvdXhjxb X-Received: by 2002:a17:906:f84b:: with SMTP id ks11mr1476093ejb.114.1589524772193; Thu, 14 May 2020 23:39:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589524772; cv=none; d=google.com; s=arc-20160816; b=IXpxa8C+JMsQxuhpwQDk652+C9V8mLsdE9hfrfydxOJn6lNPTvGG820qYUH3juE2QS qsJl91dNtjN99+VrJL7FVLViI5wXTAzyk3aESI+6XHI0hWcUWqnopzLYR91aaF0v7Ex2 VBV2g/t71nJ120CWRnw5A7N4jOqtkdeb0/9wFScgqgJSGY+ApnljUrHblE2iEudGTpqF 8tfkPG07Wn93t+I6cUnUgJIJSG0NpzN5Jv/EXajwW68DhYY/AOOvN7lKByX074Pejrj/ daIFvbkmDiJjIpnFvMZOCCFJ9uYJr2veymXEdd1gDigpVsK24sxM0aNJWfThJK6O1NF7 juWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Yv7xb3WoIYLLRDcl9q4wjSr80me1WIreG1r9qvxz128=; b=QM+Mtkb/lYsUZI2dkAJbgiuxMP2x7dPHjfnlUNGIyH87zAw9i8ib+ATuE6kMmNpcSh INDYAhQQhpQyMGtIyoi68Yt2BgdxOJ00j1o3InmwH3yLZ05tJ+H+1dzZhSOJgz3iDZG7 06HEc5dKj0PcttymcWRnVX8QNU3DhYytzfPGUGgTJqHIzCNCb13bUFqVZdR7etFYmcp0 KJRtDcyoy7L4wrDyyp92bdeHA0LnLDrtt6ge5SusyMtZxIk9kuZkdEdSUIfK1dZg6A82 J5JX/pxlgNB2Ci3W4vxDf/kxRb35RTquG+VjOeD4Q6ap1krgaD/Skdq2I9jDAcW1wcXz BSJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xxppYZUv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k11si592422edj.518.2020.05.14.23.39.08; Thu, 14 May 2020 23:39:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xxppYZUv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726407AbgEOGhl (ORCPT + 99 others); Fri, 15 May 2020 02:37:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:50884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbgEOGhl (ORCPT ); Fri, 15 May 2020 02:37:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 718992065F; Fri, 15 May 2020 06:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589524660; bh=/sejV8BirlA+9XJW7afKnpotS1fQXEqPb8/TeQ6TDYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xxppYZUv2kisbDZrnltv/c6K4fzrP9l7WQz1h1yifRH3No6IR1HFWaAEvQdB6QxOn Yo376PHcJjyyqnHjzp8yJ5swSubvROWSCeI4gp/Q3z0YET3LnSw8T8+nnlJxz3Qt7V +V7jy71pWwfHu+RtWWNHDBIB7V8aJJi57utGHspQ= Date: Fri, 15 May 2020 08:37:38 +0200 From: Greg KH To: Jeffrey Hugo Cc: arnd@arndb.de, manivannan.sadhasivam@linaro.org, bjorn.andersson@linaro.org, wufan@codeaurora.org, pratanan@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/8] qaic: Add skeleton driver Message-ID: <20200515063738.GA1006524@kroah.com> References: <1589465266-20056-1-git-send-email-jhugo@codeaurora.org> <1589465266-20056-2-git-send-email-jhugo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 14, 2020 at 06:43:06PM -0600, Jeffrey Hugo wrote: > On 5/14/2020 8:07 AM, Jeffrey Hugo wrote: > > +#define QAIC_NAME "Qualcomm Cloud AI 100" > > > +static struct pci_driver qaic_pci_driver = { > > + .name = QAIC_NAME, > > A question about the community's preference here. > > Our driver name is very verbose due to the desire to have the proper > "branding". However, I can see it being a bit obtuse, particularly in logs. > > Would the community prefer something more succinct here, such as "qaic"? Make it the same a KBUILD_MODNAME and then no one can complain :) thanks, greg k-h