Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp293993ybk; Fri, 15 May 2020 00:30:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMXshCsszyJTQ/RiX4rh+3wTNyVoCcniata0XhkMvx0Cs2B5pRo+Lf+bwOqI+k3be/435p X-Received: by 2002:a05:6402:b83:: with SMTP id cf3mr1253104edb.127.1589527841602; Fri, 15 May 2020 00:30:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589527841; cv=none; d=google.com; s=arc-20160816; b=iPT1Ui+/Sfad1jRB1wAPsK5givb6gQa592+h4NREKhJGugygW/rcug8Oh8nRTh0nJk ekK4ryF+4aJd1Jp37iUrgTEf93fyuMFJYtXJCBdPOmbHiH0MWCOgjjsLM/AYzo5ZTfzs zaMVvbZ6PWg/WRX1NDfRGbZI6CDJ/Zy5n7ILGFysOJ1gJFgB3R3TsQQrnt+bPd1cmug2 N5vUUmfoDuOFDzbqDQPATK9DuH3Ly6+q4EPWedxUKVD9UJ+tfJPBd2/UsK1tSuLG1cjk /OTu8oGF5rdDq7Jj097ONa9fkjJQD7jZ7yws1hCPtCG6EUP8JsFJHOY6pRAZAFxyRaXg D5+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=yQ+8bQqVXCGgiMZpHhx8CRsJZ+7vvYouTuTdyPbncmE=; b=yMsMo4zPf209fEA/KylscMEjCmlB7kBqfs4YT3bNl3FF9jKcaEM2vNYXq7E1XUtcYp gU5Sh8QktP8PjWXlDhumEEplRzUHipTNbJsx0EC/6qypfW1efNoUHoFDfvghzkjSDVWs jlnQreBSBS3+xAynBZ/3erxMmR/nZ3QBMCSmWlcTmRsWY+Ii3TFOsOsxxOQnhNeU2GQy LsWYB3aIMlCeLRgtWoIO/QH0O6NU4fLMR655MRnLHEwXtn09DItG79dUU7he3IDyzesc mmVitUcAPVO5sxzbCcIm4vbC7j/AWd4SXq0FNWcGDnEa+nEI/P4vvxlBdLdMrKlT/oJZ 6HWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QDWBz3RU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e17si721236edr.16.2020.05.15.00.30.16; Fri, 15 May 2020 00:30:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QDWBz3RU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726706AbgEOH02 (ORCPT + 99 others); Fri, 15 May 2020 03:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726434AbgEOH02 (ORCPT ); Fri, 15 May 2020 03:26:28 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21405C061A0C for ; Fri, 15 May 2020 00:26:28 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id g20so606672qvb.9 for ; Fri, 15 May 2020 00:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yQ+8bQqVXCGgiMZpHhx8CRsJZ+7vvYouTuTdyPbncmE=; b=QDWBz3RUFZANTCfesmQRxLfudLR6lDXvkwQiP0JZK/Zi3SINJJlPUbU6EqOQgQFhj3 jneZ5wcaAmgNP6xRm91oVntIzCcCm4+IDgxkpG7k2AMTSmKapOyCRKa6SzRWtAkIlknt 3Vjoy1l/UAQSqOIQpSYl083UGeHjb01hQBypU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yQ+8bQqVXCGgiMZpHhx8CRsJZ+7vvYouTuTdyPbncmE=; b=sYKSwqgzDtNOV5Fecwnjz8UGBWHK1V3dj5e1WZBVfaQ//HiG9AH8atkucSKZI57O2v xiwtiyrNbjFUVyHb28qWQX6RM61D5eafkS7oa6l/8vVaiU7UJyvDzLmTOz+7q5A3PQ7P 8JAwlHwzJAbu6h2KFBTzq3/2xpIWe22kvSfA3I2bub24H6Vdu3UltZCIUCGfPbBxZ7J4 Og7h0doTP0vrmYSxXEs+ruDAmfRs29PBsDaemvZHQ0R0eYxuHUqwaC4q3bhoK368pwsn tSWXn5MF93xqXNbuSvNI05bZaO60Tb0WwZ2djtBRoIhjefs8nTj/6niEOKUJkewqAne9 EA6g== X-Gm-Message-State: AOAM530r+AcgRHjqQFZY1LtSvucvvDtzVV6+Ur2GWLrPCcjui20q6wGz yXnzmZGs6MuvN9joW6FdFiRPOVbK+57bb/ih2fmu3T1Yz5U= X-Received: by 2002:ad4:580b:: with SMTP id dd11mr2192873qvb.145.1589527587111; Fri, 15 May 2020 00:26:27 -0700 (PDT) MIME-Version: 1.0 References: <20200311112004.47138-1-stevensd@chromium.org> <20200311112004.47138-5-stevensd@chromium.org> <20200513123326-mutt-send-email-mst@kernel.org> In-Reply-To: <20200513123326-mutt-send-email-mst@kernel.org> From: David Stevens Date: Fri, 15 May 2020 16:26:15 +0900 Message-ID: Subject: Re: [PATCH v3 4/4] drm/virtio: Support virtgpu exported resources To: "Michael S. Tsirkin" Cc: Gerd Hoffmann , David Airlie , Daniel Vetter , Jason Wang , Sumit Semwal , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , open list , ML dri-devel , "open list:VIRTIO GPU DRIVER" , Linux Media Mailing List , "moderated list:DMA BUFFER SHARING FRAMEWORK" , virtio-dev@lists.oasis-open.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_RESOURCE_UUID)) { > > + vgdev->has_resource_assign_uuid = true; > > + } > > > Just a question: this relies on DMA bufs so I assume it is > not really assumed to work when DMA API is bypassed, right? > Rather than worry what does it mean, how about just > disabling this feature without PLATFORM_DMA for now? By PLATFORM_DMA, do you mean CONFIG_DMA_SHARED_BUFFER? Virtio-gpu depends on DRM, which selects that feature. So I think DMA bufs should always be available when virtio-gpu is present. -David