Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp299447ybk; Fri, 15 May 2020 00:41:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQnHlaAA36+rfGUIJnhvxrK4/juz6HF2yHJgOLESWFOwJI4Kb/+aniDJQ9PiyhQ48Zlk4C X-Received: by 2002:a17:906:d14b:: with SMTP id br11mr427573ejb.144.1589528511707; Fri, 15 May 2020 00:41:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589528511; cv=none; d=google.com; s=arc-20160816; b=yMLOTPPkmQX1nOXckDxEQlvo3NvNaNDrWAgO2zrTON3z/Gg5HSgxh/NoGwqKHMb9tq kSPZ/+cc9+KszWRYVk7kRtiazIzNhnrqszpSRlGVF3EnGsHGI80edmuRmNS0atdLoPq5 G7fGvtAjv+m6uuqig0iLqQrDm6Aj2GdCb1muZ+/pNPRd1m1Hh+Ym1TKe1VoqrbsB/nXx 581JkV/+6sXPanwUT/A+MDkU9qz05d+pJ4QmNTWfwpQ+kdiS99quhZrI2I1Yevqs5jtZ UDZp7IPClPh9eHA7+LdE974K4B/HrAnOn6CjLM1xFBq55wp7KzqKKBmnRIcMoGdKWRRm FZ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0RhSSYbFcWNN9utYce+rTOVTkfNbtBp3WO7H+4IVWHg=; b=YQzhDKZCgLjSLVo82uXYCLnQZYVEWjEsY71hkHA1uyqmLFBfqI9a3AtjZOyvuiOc6m oTNhCk58T8rfFHmgmc4PRUnS0QpOAkrS/tBhIKMoFPURi+7Eip1/ukJly7ZZl+rk6jL9 SOxG1z2ZYhmKx5obebQNGpe/v08RwWch5QIg+d3IgDM2vyhwpvju0RnpLHR8Vm1VMlLR /8ACMiApu/IHWXzXPBdXdN4jozS2YfI6Iv8H82N8eyYPho3/VJiAllprZfVVeaFwq6u8 EQNcLdZWheaS4FX08bU2z+VIDgCD5eNmw7oc+bnmyVyJEf1NnUqTb1PZbpZANzs/uYa4 93/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si614046edh.605.2020.05.15.00.41.28; Fri, 15 May 2020 00:41:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgEOHj4 (ORCPT + 99 others); Fri, 15 May 2020 03:39:56 -0400 Received: from elvis.franken.de ([193.175.24.41]:54067 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726624AbgEOHj4 (ORCPT ); Fri, 15 May 2020 03:39:56 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jZUwf-0007Id-00; Fri, 15 May 2020 09:39:49 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 3F748C04A0; Fri, 15 May 2020 09:39:38 +0200 (CEST) Date: Fri, 15 May 2020 09:39:38 +0200 From: Thomas Bogendoerfer To: Tiezhu Yang Cc: Huacai Chen , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li Subject: Re: [PATCH v2 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT Message-ID: <20200515073938.GA8289@alpha.franken.de> References: <1589512985-27419-1-git-send-email-yangtiezhu@loongson.cn> <1589512985-27419-2-git-send-email-yangtiezhu@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589512985-27419-2-git-send-email-yangtiezhu@loongson.cn> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote: > When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix > the following build errors: how are you doing this ? To me it looks like this CONFIG option isn't used anymore. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]