Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp313994ybk; Fri, 15 May 2020 01:11:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvJ+3O+5HP77w6NdQz/jfR/kIvhxW3wINdGE1deYySoBDPAspsMyseEG1+IyVRvAFuSJR4 X-Received: by 2002:a17:906:860a:: with SMTP id o10mr1737821ejx.250.1589530286801; Fri, 15 May 2020 01:11:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589530286; cv=none; d=google.com; s=arc-20160816; b=va5Rfy7VlEoEQcqPpSnMM9bOT36goJOCVk2k94BuLfr2GOtkFXlCkpch4tPtNQug5N fYAV3pXzkAZSC9jrOxLlVl3f//QAhkRB4feJKIgwjIxgPdlkYyQU4X1+XmSm+NsPgNC2 NY10WwcmfLIr4ZmHC9TTodcyBYeJvKDP9LAqJ0PTzksjXW51lT3lz/21eXri69+Y40I+ L3K8thYTghwiPMrlM+bkFpSpZ5y4F6b4V9Lm9sUHpzvuM07uSyrcpWTNCdUSqU+5ang8 Lqj/wnL20d13sKDCHOnUJiGWvtwy7MJB/XUv2sYb4MGrW4O84OCZJ1drQG2rWIAtYqL9 MvxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=1vyc3N6Wpm82JIZilzNLGJALVVKWdLUl/sk+JrP3SQY=; b=HQQCEAKg7XURpfHcJrDFyaoE4Z4VBY987Gb2uRVEtlSBysjYcPlOCtXZaDdmCaViON fJWHEPtOhr5lRFLwT0PcQoHE6Drj+Hx06/kivmnk8z/9sarwlI/uPCaIuF+fXdwOCFPL CP60pdBC5iWebd58qcBLud+WZnL5OhEp7u9xYw4zsJgHjnkfR1MQVhBUksOGdcoP0eMH 1CrwpZ2Chy+ojeQDkQ+OYXaduD7OnYA29vH0rddFULVePk/+vrmIzcsNZed7pTFwB1Ju U3euOZbJmIELO1exaahfojyRrQh3K+7c3OxUmc+bsaCwnc/DlSJjGZM7/6Opk4WxF2+h sD7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WfQKqFbs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ov4si742503ejb.237.2020.05.15.01.11.01; Fri, 15 May 2020 01:11:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WfQKqFbs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbgEOIJd (ORCPT + 99 others); Fri, 15 May 2020 04:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726648AbgEOIJc (ORCPT ); Fri, 15 May 2020 04:09:32 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81177C05BD09 for ; Fri, 15 May 2020 01:09:32 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id y25so617154pfn.5 for ; Fri, 15 May 2020 01:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1vyc3N6Wpm82JIZilzNLGJALVVKWdLUl/sk+JrP3SQY=; b=WfQKqFbsR7j0aT0EBVSN2m33HEItYHviYT/e/Oyrp6O+5EmrwjqvbC5f+YgJHhS/Ml 5HZLGNLbbHysm+MGzdihZhtYNWYX/2aurTMWuP6AqSQFXitKJTySL+XS5PZt21DhvH1K AkCIkBjKMNiC6QdGXn+Qi0B43psoWAOmYK2ZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1vyc3N6Wpm82JIZilzNLGJALVVKWdLUl/sk+JrP3SQY=; b=WNYU0jNtjZG3UOyqUixh36eSRljqtjumLjGwfbIpm7Psxiev3pLnNkYjN68ozGt2PD sUm6+hRklB9NzT9M0gSKIXy1Jytv7vCPQhMhjhhqVMIEsc6IPGFv1QrdMi893iKULcby URoxm/dI2kZMOcMsK8jxxgFPwCKwO7H8smTvkxtoTuj1aJ60oTBUuEnuSk9MYdUoXAvr 9sztV1vY7uZ8ux3bWLuZp8cmxtnHgNrIeg/VhjODqzxg74U7haDBuYHv8GZljtJu+gwG T3ChyNoXgBfVoqYIULv4/I86Et3I+M650Y4F6FD0hwhOQ76bcpzjHob5FcO5ywFiBw5S 3gEg== X-Gm-Message-State: AOAM531JpFCcScCurRJNpVIIcQrrUQP3dktH7KHHJ+z+LLNx1J0hb8J2 lUqw3y1HSLl5gzlh7ukxdoyWjw== X-Received: by 2002:a62:ae13:: with SMTP id q19mr2697929pff.310.1589530171972; Fri, 15 May 2020 01:09:31 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y14sm1222453pff.205.2020.05.15.01.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 01:09:30 -0700 (PDT) Date: Fri, 15 May 2020 01:09:29 -0700 From: Kees Cook To: Xiaoming Ni Cc: mcgrof@kernel.org, yzaikin@google.com, adobriyan@gmail.com, mingo@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, yamada.masahiro@socionext.com, bauerman@linux.ibm.com, gregkh@linuxfoundation.org, skhan@linuxfoundation.org, dvyukov@google.com, svens@stackframe.org, joel@joelfernandes.org, tglx@linutronix.de, Jisheng.Zhang@synaptics.com, pmladek@suse.com, bigeasy@linutronix.de, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, wangle6@huawei.com Subject: Re: [PATCH 3/4] watchdog: move watchdog sysctl to watchdog.c Message-ID: <202005150107.DA3ABE3@keescook> References: <1589517224-123928-1-git-send-email-nixiaoming@huawei.com> <1589517224-123928-4-git-send-email-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589517224-123928-4-git-send-email-nixiaoming@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 12:33:43PM +0800, Xiaoming Ni wrote: > +static int sixty = 60; This should be const. (Which will require a cast during extra2 assignment.) -- Kees Cook