Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 May 2020 16:19:52 +0800
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
To:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
CC:     Huacai Chen <chenhc@lemote.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH v2 2/2] MIPS: Fix build errors under CONFIG_HAVE_STD_PC_SERIAL_PORT
User-Agent: K-9 Mail for Android
Reply-to: jiaxun.yang@flygoat.com
In-Reply-To: <7715fe64-5d28-f8c8-3b04-0bf2b9f16497@loongson.cn>
References: <1589512985-27419-1-git-send-email-yangtiezhu@loongson.cn> <1589512985-27419-2-git-send-email-yangtiezhu@loongson.cn> <20200515073938.GA8289@alpha.franken.de> <7715fe64-5d28-f8c8-3b04-0bf2b9f16497@loongson.cn>
Message-ID: <5AA0EB3A-DF33-4BE7-804C-45F6B51A0CF7@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


=E4=BA=8E 2020=E5=B9=B45=E6=9C=8815=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=883=
:54:46, Tiezhu Yang <yangtiezhu@loongson=2Ecn> =E5=86=99=E5=88=B0:
>On 05/15/2020 03:39 PM, Thomas Bogendoerfer wrote:
>> On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote:
>>> When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module=2Eh t=
o fix
>>> the following build errors:
>> how are you doing this ? To me it looks like this CONFIG option isn't
>> used anymore=2E
>
>Because I will use arch/mips/kernel/8250-platform=2Ec in the near future,
>so make MACH_LOONGSON64 selects HAVE_STD_PC_SERIAL_PORT, then
>I find the build errors=2E

Please never use it=2E
If you are willing to add serial port then please do it
in devicetree=2E
Platform devices in wild is dangerous and it will break everything=2E

>
>Thanks,
>Tiezhu Yang
>
>>
>> Thomas=2E
>>
>

--=20
Jiaxun Yang