Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/2] MIPS: Fix build errors under
 CONFIG_HAVE_STD_PC_SERIAL_PORT
To:     jiaxun.yang@flygoat.com,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
References: <1589512985-27419-1-git-send-email-yangtiezhu@loongson.cn>
 <1589512985-27419-2-git-send-email-yangtiezhu@loongson.cn>
 <20200515073938.GA8289@alpha.franken.de>
 <7715fe64-5d28-f8c8-3b04-0bf2b9f16497@loongson.cn>
 <5AA0EB3A-DF33-4BE7-804C-45F6B51A0CF7@flygoat.com>
Cc:     Huacai Chen <chenhc@lemote.com>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <db6fda56-27da-3705-1270-805e61defe4b@loongson.cn>
Date:   Fri, 15 May 2020 16:54:09 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <5AA0EB3A-DF33-4BE7-804C-45F6B51A0CF7@flygoat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05/15/2020 04:19 PM, Jiaxun Yang wrote:
>
> 于 2020年5月15日 GMT+08:00 下午3:54:46, Tiezhu Yang <yangtiezhu@loongson.cn> 写到:
>> On 05/15/2020 03:39 PM, Thomas Bogendoerfer wrote:
>>> On Fri, May 15, 2020 at 11:23:05AM +0800, Tiezhu Yang wrote:
>>>> When CONFIG_HAVE_STD_PC_SERIAL_PORT is set, include linux/module.h to fix
>>>> the following build errors:
>>> how are you doing this ? To me it looks like this CONFIG option isn't
>>> used anymore.
>> Because I will use arch/mips/kernel/8250-platform.c in the near future,
>> so make MACH_LOONGSON64 selects HAVE_STD_PC_SERIAL_PORT, then
>> I find the build errors.
> Please never use it.
> If you are willing to add serial port then please do it
> in devicetree.
> Platform devices in wild is dangerous and it will break everything.

Hi Jiaxun,

OK, Thanks for your suggestion. I will rethink my plan.

Hi Thomas,

Because CONFIG_HAVE_STD_PC_SERIAL_PORT is not used anymore,
(1) Is it necessary to fix this possible build error?
or
(2) Should we remove this arch/mips/kernel/8250-platform.c?

Thanks,
Tiezhu Yang

>
>> Thanks,
>> Tiezhu Yang
>>
>>> Thomas.
>>>