Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init
To:     Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
References: <1589508901-18077-1-git-send-email-yangtiezhu@loongson.cn>
 <1264becb-44aa-9e29-4e67-d1b5fbc0b56c@cogentembedded.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xuefeng Li <lixuefeng@loongson.cn>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <9472816e-f97f-349b-2f7c-6c6c636f5fec@loongson.cn>
Date:   Fri, 15 May 2020 16:58:32 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1264becb-44aa-9e29-4e67-d1b5fbc0b56c@cogentembedded.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05/15/2020 04:51 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 15.05.2020 5:15, Tiezhu Yang wrote:
>
>> When ATI Radeon graphics card has been compiled directly into the kernel
>                                ^ driver

Hi Sergei,

Thanks for your review, I have been sent v2 with the updated commit message:
https://lore.kernel.org/patchwork/patch/1242218/

Thanks,
Tiezhu Yang

>
>> instead of as a module, we should make sure the firmware for the model
>> (check available ones in /lib/firmware/radeon) is built-in to the kernel
>> as well, otherwise there exists the following fatal error during GPU 
>> init,
>> change CONFIG_DRM_RADEON=y to CONFIG_DRM_RADEON=m to fix it.
>>
>> [    1.900997] [drm] Loading RS780 Microcode
>> [    1.905077] radeon 0000:01:05.0: Direct firmware load for 
>> radeon/RS780_pfp.bin failed with error -2
>> [    1.914140] r600_cp: Failed to load firmware "radeon/RS780_pfp.bin"
>> [    1.920405] [drm:r600_init] *ERROR* Failed to load firmware!
>> [    1.926069] radeon 0000:01:05.0: Fatal error during GPU init
>> [    1.931729] [drm] radeon: finishing device.
>>
>> Fixes: 024e6a8b5bb1 ("MIPS: Loongson: Add a Loongson-3 default config 
>> file")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> [...]
>
> MBR, Sergei