Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Jun Li <lijun.kernel@gmail.com>
Cc:     John Stultz <john.stultz@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Yu Chen <chenyu56@huawei.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        ShuFan Lee <shufan_lee@richtek.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Jack Pham <jackp@codeaurora.org>,
        Linux USB List <linux-usb@vger.kernel.org>,
        "open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, peter.chen@nxp.com,
        Li Jun <jun.li@nxp.com>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Subject: Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller
In-Reply-To: <CAKgpwJXfWv5=MDqBCADhe2iXf6eiP0GQ13Bwo9fkuU5kGO7dsw@mail.gmail.com>
References: <20191028215919.83697-1-john.stultz@linaro.org> <20191028215919.83697-4-john.stultz@linaro.org> <87mudjj4rc.fsf@gmail.com> <CALAqxLU+9uEcdRVaLfh+eQrDtZbDGod9pRXhBX=prAhg9MXagw@mail.gmail.com> <CAKgpwJVaKpsgMjKcnYyJsfNj0ibkPt=mdn-NxfOkeX1jfL=9iQ@mail.gmail.com> <87h7wqmwrv.fsf@kernel.org> <CAKgpwJXfWv5=MDqBCADhe2iXf6eiP0GQ13Bwo9fkuU5kGO7dsw@mail.gmail.com>
Date:   Fri, 15 May 2020 12:31:07 +0300
Message-ID: <87imgx35pg.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Jun Li <lijun.kernel@gmail.com> writes:
>> @@ -397,12 +407,18 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, u=
nsigned cmd,
>>                         dwc3_gadget_ep_get_transfer_index(dep);
>>         }
>>
>> -       if (saved_config) {
>> +       if (saved_hs_config) {
>>                 reg =3D dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0));
>> -               reg |=3D saved_config;
>> +               reg |=3D saved_hs_config;
>>                 dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
>>         }
>>
>> +       if (saved_ss_config) {
>> +               reg =3D dwc3_readl(dwc->regs, DWC3_GUSB3PIPECTL(0));
>> +               reg |=3D saved_ss_config;
>> +               dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(0), reg);
>> +       }
>> +
>>         return ret;
>>  }
>
> Unfortunately this way can't work, once the SS PHY enters P3, disable
> suspend_en can't force SS PHY exit P3, unless do this at the very beginni=
ng
> to prevent SS PHY entering P3(e.g. add "snps,dis_u3_susphy_quirk" for tes=
t).

It sounds like you have a quirky PHY. If that's the case, then you
probably need to use the flag you mentioned above. Please verify with
that.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl6+YVsACgkQzL64meEa
mQbdgRAA2/XUFT7mg4gDxdDx3PjeMl7KW1uDTUiFf7LeQT4Vwkqq2epxcPwqjaQU
Bnt4CLX2TGgdmL/IntNlpU9i6M3a+IeDZM0D+S7/NK1Ty2iMuQ0kGA6wZOfUdbY+
RpA6Yrl1DkqQ6pMsLUYkDyGauPx7qFOJ8mx4XDEjX7v6fI/AcKkDMCx/Yuj89zhd
Yf56yxVKq/tiDOe7U7IC/IpEx9Zt7TGEVUqSotC+23A08/YBiKy229Qv5v9KkoXt
VP0xHBZGPBnEQ79rCZHxj8M8E2nDmYSLqvAOwDp27EeQNq1j/6XMlzk2bR1jvnpq
s78lCPBLGoJc/8WVgBJtLZ0BTLKPctS17xatz/3gtgd8sX03ddyp4cG+xMVKC16f
1kbOg820KTvr1UDgaMq3Bo9lFTFCkOg25WYHx4c1/w/VeclRpfK+2QVqXE0eZ/ME
8d9oM9tCKILQc1SlSy9tHwKRj5+KCd993CzSyMuMwMO1RqM+nadmQJMcexiquxiS
T5rHakbLtnpimLfO7SEi/OvuypKkWhLt52JTwgech584qyKWVh3tR/QbZCPMo7Dj
IAyB80gcRaVN5kZjfdTOeSxUpjuJuJujUwmgFhw/00nqBJ3EPogo6F8n2WDCORpH
kybGfZw3RrMTtrfd0gQU4rZf6Cel6kE+L7Jjy7skyJ466XjfTpU=
=hLf8
-----END PGP SIGNATURE-----
--=-=-=--