Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp362777ybk; Fri, 15 May 2020 02:43:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEg+1+CkCdDM/i55rjdtV4RyAox0UkB9i/hKfy1xYPNJv6fWTb24K4as97Kg60Llm5khDr X-Received: by 2002:a17:906:52da:: with SMTP id w26mr1771902ejn.143.1589535816801; Fri, 15 May 2020 02:43:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589535816; cv=none; d=google.com; s=arc-20160816; b=asZq7LJNghwqLw6UM9S66RkPDa4/GO1zfuSnJPu0mT3BiB9q/cxb4UaNOuBA0UfpXa tzJv4vjdhQW8xtDO1U6X4Y2lm9qnuYHZqoflSBUkX1B2KQxmFAiaNQzVJ3n0M8Ob5jdt bAQBT0kNkp4ptD0SIgd9z+MpTAWhVt75s6TE5H0fLxTe2fUNS9/MX0VUb9+o01qfkWar iHEkw9thkAXiAVN2Ajc5YiwINmKQUvL86/2MQQ6o8mum3BZ5Y7+IWALmtHbpm49yV4pf tCUB1hNxxRLEzd7RlSL1KnFPTotD8Ey9csXAQhysN2tBEC/JbuLtnHdCudOzwmQJ/BPZ SU8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=rKmZCcVKTIVgCO+z+GlkssBEJpYMxklWqKhfYU/OBVw=; b=JaugJv/ZFX6/VYnQzzjB7gWg19dFAnVtKHwIlu4KII6CZyn9ypXnyXl5w8WC2wpiOi BJ+VU0Ej08mwTvpN20vAyzObaHGLWGwmKl9u3gNEECnsza3KvveBDQ5HIkqXgpDBZoXw IRJ7fKoZhbSkK3wpqEiPGPmvw/qD9EUb89acmBxwccNoU5xWjeO8peCB4IV2mMhzr1pm nT60Lxy8zglw32ace9owxlR3SCl+dID3/94RzuAGcNpP2H/vkz+UwADxP/4a3tO6j5zV dMg4KsG9PgHzGvCsMwmqBYbm5HXYqvJLffsQILy5lS+kcmtLBCdKW1Q6FmiUYH/zpo0B vsBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZlAfy2qQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si857742ejx.259.2020.05.15.02.43.12; Fri, 15 May 2020 02:43:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZlAfy2qQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728113AbgEOJkt (ORCPT + 99 others); Fri, 15 May 2020 05:40:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727898AbgEOJkt (ORCPT ); Fri, 15 May 2020 05:40:49 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 736E7C061A0C for ; Fri, 15 May 2020 02:40:49 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id hi11so684109pjb.3 for ; Fri, 15 May 2020 02:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=rKmZCcVKTIVgCO+z+GlkssBEJpYMxklWqKhfYU/OBVw=; b=ZlAfy2qQSjg+yhOrlIGiA3r33pwsHJXBZMFY9e1KDLMutt0i9qo/LPRiXgBSJ05d3w PHya8TF0no0u/FdQAiTrM7w4dNQ0MOKkdwPVc4GHANK3hUiclzAyq289ERuk3o9a20hd MDb1bCT7DYdwlVX8H/9xkmwPkNsveya+KVBm9UWN1mOzGaiJZXAwHQcH0sQModNr8Oj0 pHt7tD7Z1/sLD6zRihXl2lrGAG6lk9RgvcYL+rcAk82XFy5J1JJFHb6Rxh1G748MSTP1 nfrplRHTdK7PwBPxIhsZwHUHTRmgsHnE+wRUDhQ2nMzzXvmF6tkhy7Xp1RemztOCmwJ2 F0fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rKmZCcVKTIVgCO+z+GlkssBEJpYMxklWqKhfYU/OBVw=; b=RTrX3Bqt8W2syb8fUfJ7V6xpmDc0KAbP002xlT5qvoK6ZcadGNepMT6pKrzBpFIOJd 8VUHDRGaYaMhV9uod6ky2OR7r6NPZRTjiWFuRs3uWhL48fvEZHTnquqApdVLA6FQeeXT oYRLwaR4Y2eEwX9t1Svz/VB38BQQR2itBPtuFkUaEOqVK767BEOYNRjpWLsy3YAR1Rsc OZNpt53kySrTmhiGX/osTZH0uA9xG9qihxosNJYNwFfZKEXocrIIfj+A1Wcoh4K0Bcay 2ZMv48Iph6PDD49g+5W8b29vgaYDh1g2xXyiheneSkr3rZVcwfMjJdHMjPmdiXPJaTHR PXCA== X-Gm-Message-State: AOAM533qZlE4m4Ob7VWKwD14iC6hEvnfHvwze/B709qimgY4leMGIHwI vSn5y0od0XhXQVYNcgME3EE= X-Received: by 2002:a17:902:599b:: with SMTP id p27mr2586551pli.75.1589535649041; Fri, 15 May 2020 02:40:49 -0700 (PDT) Received: from localhost ([43.224.245.180]) by smtp.gmail.com with ESMTPSA id z13sm257789pfj.153.2020.05.15.02.40.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 May 2020 02:40:48 -0700 (PDT) From: heshuai1 X-Google-Original-From: heshuai1 To: gregkh@linuxfoundation.org, vkor@vkten.in, nishkadg.linux@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, heshuai1 Subject: [PATCH] rtl8723bs: core: fix a coding style error Date: Fri, 15 May 2020 17:40:44 +0800 Message-Id: <1589535644-6820-1-git-send-email-heshuai1@xiaomi.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix this coding style error reported by checkpatch.pl: ERROR: do not use assignment in if condition #1120: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:1120:: + if ((addr = of_get_property(np, "local-mac-address", &len)) && Signed-off-by: heshuai1 --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index ca98274..06be1d4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1117,8 +1117,8 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr) } if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) { - if ((addr = of_get_property(np, "local-mac-address", &len)) && - len == ETH_ALEN) { + addr = of_get_property(np, "local-mac-address", &len); + if (addr && len == ETH_ALEN) { ether_addr_copy(mac_addr, addr); } else { eth_random_addr(mac_addr); -- 2.7.4