Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101AbWCNC0S (ORCPT ); Mon, 13 Mar 2006 21:26:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752099AbWCNC0S (ORCPT ); Mon, 13 Mar 2006 21:26:18 -0500 Received: from CyborgDefenseSystems.Corporatebeast.com ([64.62.148.172]:26636 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S1752098AbWCNC0S (ORCPT ); Mon, 13 Mar 2006 21:26:18 -0500 From: Herbert Xu To: bunk@stusta.de (Adrian Bunk) Subject: Re: [2.6 patch] hostap_{pci,plx}.c: fix memory leaks Cc: jkmaline@cc.hut.fi, hostap@shmoo.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Organization: Core In-Reply-To: <20060313222841.GQ13973@stusta.de> X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) Message-Id: Date: Tue, 14 Mar 2006 13:25:29 +1100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 29 Adrian Bunk wrote: > > + if (pci_enable_device(pdev)) > + return -EIO; > + > hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL); > if (hw_priv == NULL) > return -ENOMEM; > memset(hw_priv, 0, sizeof(*hw_priv)); > > - if (pci_enable_device(pdev)) > - return -EIO; > - You've just turned it into a leak of a different kind. Why not jump to the error exit instead? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/