Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp388205ybk; Fri, 15 May 2020 03:26:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAnPfy9i5Iasa2wlTVXa4tz5VSImD1+fDprWcENj6m4ReAYtUwKL+viMSynRbJps3cUrPx X-Received: by 2002:aa7:df8d:: with SMTP id b13mr2121781edy.145.1589538403759; Fri, 15 May 2020 03:26:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589538403; cv=none; d=google.com; s=arc-20160816; b=vsHxWAJ2Cq0PwnEukDLP9kWbzb8+iqpbp1Iumt2uEBRNp28Zy8HCDtMvG/6iN72jVu syL0zLkArBsvcd6Vl4GomuF/09+mUouzkM3noobHq527i41ODtjdI6YxywU7JXrsfka+ XgmKc/y3xB2LDG3h3cZeu0pLQeV+JkO40WezW/hznjMPoxzNGUidljbrASFPs8UqnB6J b0pD0AyQGtroBiexgkcAv91DpEXHOfNmXv9ajqOyqQRMTOIPSqwOTU/um1FQECEC6uBM SAmxn3dMwOOGNTC/WzLDE6I+M+Y/DwBJilZ+MIqNo+xyLIW0nXVjaxrP0D+N/xJlbFZI ZXDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :dkim-signature; bh=PGybp4d555g//9H3GiWo4hvFh60jsI+s9m8Oige6iHM=; b=Ev+c+G5lZBZSQw2LrNEPc/TWtzig7vxEzW1sFoq0O6kCRShn52aSr9FUfAmEq1cVBn RfkwIspVIHOdutMOGO9X+P5jh7S9FgmQd3l2BeSkH6yvrxBFgb+Xwq2sOEZFt55vFiZu gtwagohJXpnNrXA4+RnZAgE6M0AJ8uOefrOPsjhjg9YCcmqUaXrR4ARci7CezweL4fQK KJUPcICzQstiEkwI0qcpNX+LWIYueBAU7riF0oJ5DsqaiQYFtnOdyj+ntr/ltfscfMJL bsHaYaYH+2C6k4GR+as9qlJ6JCec4qq6FmGTuPU1QQuqqsLkSYP14NzJ2paZS3v0H8Pf XIqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mU7NZ5lT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i3si923248ejg.428.2020.05.15.03.26.20; Fri, 15 May 2020 03:26:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mU7NZ5lT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728190AbgEOKYb (ORCPT + 99 others); Fri, 15 May 2020 06:24:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728060AbgEOKYa (ORCPT ); Fri, 15 May 2020 06:24:30 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDD0CC061A0C for ; Fri, 15 May 2020 03:24:30 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id mq3so728433pjb.1 for ; Fri, 15 May 2020 03:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PGybp4d555g//9H3GiWo4hvFh60jsI+s9m8Oige6iHM=; b=mU7NZ5lTbT5eBu8L5irKydmLWQdyjrqCs7Ncjj9uLohQKJ+Sh7nq+Cqcks/IQjyMdv UY4CkOMjWuf/EhUm8Nrme9nle0BqJSr4o/wrW5VM61L8fiQb6STCQ6g9aMEZvrOYO5r1 hr7orQ8oqmedWZ9EuLxi0lBJDoPtlhJ0CvoRL65sUXi3tgyd7Y8O9/dc4DZF4FSmsB3Z a4icTgldsj7/BpPxyMOQbVqmglv6HatFAXiryJA0Y2q05fOSETGzE6Mi0zafN585zwGp NQQRqo2xZtOkjOPmHaqHwwt/krpwfxFW2+yh1lWvBNr6GIDjXhbVmyFVfXxUz5raBCSe IXjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PGybp4d555g//9H3GiWo4hvFh60jsI+s9m8Oige6iHM=; b=Ph+TsMMgRbTQ6+GNA37JVmyBRnopCqo6w1ZYMxlWOk/mFtk5P6bfRwgJO1vOsMgu6c qV5slcTfksvxfaUidqNSHgwMjfyGabI4DfjzekhOyxyyYTQ/B5RHB7aI+sslxZGCVJxP WIRyMY7RxAI5Nxad35GMBzgI2N+90UQQARcHLrgfWHCQI4uJ0MvLoCxCEGHqrLjhN9n5 NemDMa/eccnizyjuRqA+q6XzDVmja7wVEL3NmQZ9EnWV1tn/+CYiqsCajVKc0A0G3/1Z fHX9NWWzcRjPt/pfZHCXEiu2YJ1moDyua+HNiDXBFaqO2zvXNkc3fq6fxlOqOHyb4I+5 heGg== X-Gm-Message-State: AOAM532uzFpOaTFl9If/7pVsNs/j5btFYm8WK3a7kZnCsCIldotie3Cl 3ay3CwPKJojFSHTjpJCglAG9K3t/ X-Received: by 2002:a17:90a:e147:: with SMTP id ez7mr2724356pjb.128.1589538270185; Fri, 15 May 2020 03:24:30 -0700 (PDT) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id gn20sm1301945pjb.24.2020.05.15.03.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 03:24:29 -0700 (PDT) From: Sergey Senozhatsky X-Google-Original-From: Sergey Senozhatsky Date: Fri, 15 May 2020 19:24:27 +0900 To: John Ogness Cc: Petr Mladek , Peter Zijlstra , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Linus Torvalds , Greg Kroah-Hartman , Andrea Parri , Thomas Gleixner , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] printk: replace ringbuffer Message-ID: <20200515102427.GB42471@jagdpanzerIV.localdomain> References: <20200501094010.17694-1-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501094010.17694-1-john.ogness@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/05/01 11:46), John Ogness wrote: > Hello, > > Here is a v2 for the first series to rework the printk subsystem. The > v1 and history are here [0]. This first series only replaces the > existing ringbuffer implementation. No locking is removed. No > semantics/behavior of printk are changed. > > The VMCOREINFO is updated. RFC patches for the external tools > crash(8) [1] and makedumpfile(8) [2] have been submitted that allow > the new ringbuffer to be correctly read. > > This series is in line with the agreements [3] made at the meeting > during LPC2019 in Lisbon, with 1 exception: support for dictionaries > will not be discontinued [4]. Dictionaries are stored in a separate > buffer so that they cannot interfere with the human-readable buffer. I'm willing to bless this. The code looks good to me, nice job guys. Acked-by: Sergey Senozhatsky -ss