Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 May 2020 09:15:13 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Cheng Jian <cj.chengjian@huawei.com>
Cc:     <linux-kernel@vger.kernel.org>, <xiexiuqi@huawei.com>,
        <bobo.shaobowang@huawei.com>, <huawei.libin@huawei.com>,
        <chenwandun@huawei.com>, <mingo@redhat.com>
Subject: Re: [PATCH] ftrace: show debugging information when panic_on_warn
 set
Message-ID: <20200515091513.4947ff02@gandalf.local.home>
In-Reply-To: <20200515100828.7091-1-cj.chengjian@huawei.com>
References: <20200515100828.7091-1-cj.chengjian@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 15 May 2020 10:08:28 +0000
Cheng Jian <cj.chengjian@huawei.com> wrote:

> When an anomaly is detected in the function call modification
> code, ftrace_bug() is called to disable function tracing as well
> as give some warn and information that may help debug the problem.
> 
> But currently, we call FTRACE_WARN_ON_ONCE() first in ftrace_bug(),
> so when panic_on_warn is set, we can't see the debugging information
> here. Call FTRACE_WARN_ON_ONCE() at the end of ftrace_bug() to ensure
> that the debugging information is displayed first.
> 
> after this patch, the dmesg looks like:
> 

Thanks, I'll add this to my queue.

-- Steve