Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp505591ybk; Fri, 15 May 2020 06:28:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymEMNoYJAujkihBiY1UCaI+i79JzpE4/REiig0mGeio5+dCpvKinQI+H/KdbWNhu4zlbUN X-Received: by 2002:a05:6402:c87:: with SMTP id cm7mr2751928edb.96.1589549322911; Fri, 15 May 2020 06:28:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589549322; cv=none; d=google.com; s=arc-20160816; b=x9w2yWvhQdFz4Bf5J6lRNBggxDKVXcfk/ZOKJIcpYuiYRtIu1sae/VVVE/7r9GgkRo nhDAVpSAoERfwHLMQoH+SuLBeMp8jaJxLxvBhhkQ4UO7hWu68nQgbwIeamNKqGmPoe6M /eU0pz/io80se3npbxI7ThpeL8uhXl1WeJPsIDtif1XdkZUmGp9RvEnPLeArdOireRwY b18dfUo0Dp9XNX3OX+5jdR6l2D4fRs1Psqs1DcXvpq8W8NxvCwE14Od//7ozydT4k/+u yeidTi/7XKpqhjVHLrt80afWyFJDDt1dMU5ZeZXsN4qZi1/5Zg5rHTPDk3HxQFuwaqnl rUHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2lkBHPmlDRseinSfpjV+W/RFt5TcCXmxGmuOEC27plc=; b=Va/zjGh1Txua4VtomDisCowEK7BJ5sw5ivvznSwB1Jd7jqX9aaLIqkKwOgzLOPZDZw jp17o3by952KhUs7zn23plSafteAf2RpS1WQssyXtn4VpTGqD1gX/wR/jr/sxR8j6I2v C3c2K++VIdPkNYOOEaoqsqLRkEdQgnrHfzpLEGKuqFj4Pd7QLLtFMBU+IdKd/L4WybuH fPnXEiDEhEMdZxG5MnuUIPBGXmp5LqX2+MWIdttx8C+n9YAjqKUK7qW1zwqm+cFLVwi/ Vp6Mbj5pWrFil1jNbFC2318MXv7S/OkglJfJJkh5CG9g6VDH4iCrxfEprpYTAabgH2m9 gjRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=XDpFiU17; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn4si1147202edb.239.2020.05.15.06.28.19; Fri, 15 May 2020 06:28:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=XDpFiU17; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726246AbgEON05 (ORCPT + 99 others); Fri, 15 May 2020 09:26:57 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34018 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgEON0z (ORCPT ); Fri, 15 May 2020 09:26:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2lkBHPmlDRseinSfpjV+W/RFt5TcCXmxGmuOEC27plc=; b=XDpFiU172k5RrAaLBNhmTQlUrc jR2OibS4ZxAABJMhFVQlN9XNegRrmH9VQwX4fxx4PIMi8BnrqEwj9NpagBYhS27I/Jyw/drf1nECQ osgRt5q2QnDdGsfK64NrmFvt+ObES17pyWEhNWTDyuFsq8ISQzqmB8xp8pzdhSOhgFts=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jZaMP-002Nfr-PO; Fri, 15 May 2020 15:26:45 +0200 Date: Fri, 15 May 2020 15:26:45 +0200 From: Andrew Lunn To: Xulin Sun Cc: alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xulinsun@gmail.com Subject: Re: [PATCH] net: mscc: ocelot: replace readx_poll_timeout with readx_poll_timeout_atomic Message-ID: <20200515132645.GR527401@lunn.ch> References: <20200515031813.30283-1-xulin.sun@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515031813.30283-1-xulin.sun@windriver.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 11:18:13AM +0800, Xulin Sun wrote: > This fixes call trace like below to use atomic safe API: > > BUG: sleeping function called from invalid context at drivers/net/ethernet/mscc/ocelot.c:59 > in_atomic(): 1, irqs_disabled(): 0, pid: 3778, name: ifconfig > INFO: lockdep is turned off. > Preemption disabled at: > [] dev_set_rx_mode+0x24/0x40 > Hardware name: LS1028A RDB Board (DT) > Call trace: > dump_backtrace+0x0/0x140 > show_stack+0x24/0x30 > dump_stack+0xc4/0x10c > ___might_sleep+0x194/0x230 > __might_sleep+0x58/0x90 > ocelot_mact_forget+0x74/0xf8 > ocelot_mc_unsync+0x2c/0x38 > __hw_addr_sync_dev+0x6c/0x130 > ocelot_set_rx_mode+0x8c/0xa0 > __dev_set_rx_mode+0x58/0xa0 > dev_set_rx_mode+0x2c/0x40 > __dev_open+0x120/0x190 > __dev_change_flags+0x168/0x1c0 > dev_change_flags+0x3c/0x78 > devinet_ioctl+0x6c4/0x7c8 > inet_ioctl+0x2b8/0x2f8 > sock_do_ioctl+0x54/0x260 > sock_ioctl+0x21c/0x4d0 > do_vfs_ioctl+0x6d4/0x968 > ksys_ioctl+0x84/0xb8 > __arm64_sys_ioctl+0x28/0x38 > el0_svc_common.constprop.0+0x78/0x190 > el0_svc_handler+0x70/0x90 > el0_svc+0x8/0xc > > Signed-off-by: Xulin Sun Reviewed-by: Andrew Lunn Andrew