Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp514712ybk; Fri, 15 May 2020 06:42:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbf1PETplY0bhHsIa9FCkTYwSzqYbHWsR/gGn44OFo3p1hWUBhkOi2j0RVlGkAL+JlKhr9 X-Received: by 2002:a17:906:498a:: with SMTP id p10mr2992844eju.163.1589550140230; Fri, 15 May 2020 06:42:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589550140; cv=none; d=google.com; s=arc-20160816; b=iWEgTXtft7xD4uFNrSdnzC0ZhnUlkCPX9F0p04+qde+aLYIGWfCvID4Xzdo9bFJtNV O1DVoi/xCtyO2FvQVuAdkBF+vlT/vgJAW/7o/kJhHvLpwH/Kaafkip+IZaWvQazp8tgt khUKbX4BOp7cIWBKISrVaH1JpOVnEZlywpBnL+uvDRzBB+WBZMvfPxC+dbv1LyOojR2u xVwMaCaa41K6VbOcMRyq+Wm0eJdMO+7Jo71bve1GHlVWCCvrttDlRyXgCWbqjeaW2nYL bZzQ6esHza5a3M96CK1THMj+JvqYGLZYQiQcLGznbGIHJY6OD1DBSEZE4N2MXDq278b2 RnFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=7O/zM0NAvqChxTfX4nxkeKnjC8XczbdTIP2Xx8nIyJM=; b=qzAjnIj+efRrv6mwR+8Ca06JIUhEqnsPESI+EjuC5fvPymqZVmM8FlpSeVJMcT7Se1 bpXnfLev+tBihdFjtVqRJK251EN/7/SgOvni+B4cfqbqfLmbJ9FWHislNtkxO8WnFLWD a2aVl3bUy2ctjbjQcfHtgfhZk3cfG7Dfzl1SxZwsuhdWMVGaymOzZiFI7Y4aQ/hdMVXD DprPVa2bPHdIK0q44wN6f2D0k1jKuSPPbCQvw9nAYBVOwNPxUOVbDAzFaTLaJO11hX/D XuZq/eQFeiPFIxVPTCsEpSivFqCcT02YOFVy4GU+pciYk2kiqfypenlaU2FNvLuHQsLI gdqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DShZah10; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si1237371eja.116.2020.05.15.06.41.56; Fri, 15 May 2020 06:42:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DShZah10; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbgEONjt (ORCPT + 99 others); Fri, 15 May 2020 09:39:49 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:36583 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726170AbgEONjt (ORCPT ); Fri, 15 May 2020 09:39:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589549987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7O/zM0NAvqChxTfX4nxkeKnjC8XczbdTIP2Xx8nIyJM=; b=DShZah10VNDIQXNSU6ZAxTYDnsNBjIRRWtvOQ3wNGCiFbFiS/WsOyNxvE5yQBTxTywP8fu UawXIxzdSWIe87J/sriJQQKSFi6N9qXMrRevVIxM++ob0CqTlHALrsEaJtdkunSiiPHfqD 86mxnDP/lAZPWLLpTbeL8FvfTHw+Zhw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-420-V103GEKIOumIjCQRLXE8pg-1; Fri, 15 May 2020 09:39:45 -0400 X-MC-Unique: V103GEKIOumIjCQRLXE8pg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB33319057A5; Fri, 15 May 2020 13:39:44 +0000 (UTC) Received: from [10.36.114.77] (ovpn-114-77.ams2.redhat.com [10.36.114.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3B302FC72; Fri, 15 May 2020 13:39:43 +0000 (UTC) Subject: Re: [PATCH v4 06/36] mm: Introduce offset_in_thp To: Matthew Wilcox , linux-fsdevel@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200515131656.12890-1-willy@infradead.org> <20200515131656.12890-7-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: Date: Fri, 15 May 2020 15:39:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200515131656.12890-7-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15.05.20 15:16, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Mirroring offset_in_page(), this gives you the offset within this > particular page, no matter what size page it is. It optimises down > to offset_in_page() if CONFIG_TRANSPARENT_HUGEPAGE is not set. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/mm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 088acbda722d..9a55dce6a535 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1577,6 +1577,7 @@ static inline void clear_page_pfmemalloc(struct page *page) > extern void pagefault_out_of_memory(void); > > #define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) > +#define offset_in_thp(page, p) ((unsigned long)(p) & (thp_size(page) - 1)) > > /* > * Flags passed to show_mem() and show_free_areas() to suppress output in > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb